[PATCH] powerpc/vdso: Remove unused clockmode asm offsets

[PATCH] powerpc/vdso: Remove unused clockmode asm offsets

[Thomas Weißschuh]

These offsets are not used anymore, delete them.

Fixes: c39b1dcf055d ("powerpc/vdso: Add a page for non-time data")
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
This is based on powerpc/topic/vdso.
Feel free to fold this change into the original commit.
---
 arch/powerpc/kernel/asm-offsets.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c
index 7b3feb6bc2103bc89ea14fbaac6937f1c97d4ff8..23733282de4d9f975aa9450b26c1049688e6663e 100644
--- a/arch/powerpc/kernel/asm-offsets.c
+++ b/arch/powerpc/kernel/asm-offsets.c
@@ -346,8 +346,6 @@ int main(void)
 #else
 	OFFSET(CFG_SYSCALL_MAP32, vdso_arch_data, syscall_map);
 #endif
-	OFFSET(VDSO_CLOCKMODE_OFFSET, vdso_arch_data, data[0].clock_mode);
-	DEFINE(VDSO_CLOCKMODE_TIMENS, VDSO_CLOCKMODE_TIMENS);
 
 #ifdef CONFIG_BUG
 	DEFINE(BUG_ENTRY_SIZE, sizeof(struct bug_entry));

---
base-commit: 0161bd38c24312853ed5ae9a425a1c41c4ac674a
change-id: 20241113-vdso-powerpc-asm-offsets-056016f80174

Best regards,
-- 
Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Re: [PATCH] powerpc/vdso: Remove unused clockmode asm offsets

[Christophe Leroy]

Le 13/11/2024 à 09:06, Thomas Weißschuh a écrit :
> These offsets are not used anymore, delete them.
> 
> Fixes: c39b1dcf055d ("powerpc/vdso: Add a page for non-time data")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> This is based on powerpc/topic/vdso.
> Feel free to fold this change into the original commit.
> ---
>   arch/powerpc/kernel/asm-offsets.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c
> index 7b3feb6bc2103bc89ea14fbaac6937f1c97d4ff8..23733282de4d9f975aa9450b26c1049688e6663e 100644
> --- a/arch/powerpc/kernel/asm-offsets.c
> +++ b/arch/powerpc/kernel/asm-offsets.c
> @@ -346,8 +346,6 @@ int main(void)
>   #else
>   	OFFSET(CFG_SYSCALL_MAP32, vdso_arch_data, syscall_map);
>   #endif
> -	OFFSET(VDSO_CLOCKMODE_OFFSET, vdso_arch_data, data[0].clock_mode);
> -	DEFINE(VDSO_CLOCKMODE_TIMENS, VDSO_CLOCKMODE_TIMENS);
>   
>   #ifdef CONFIG_BUG
>   	DEFINE(BUG_ENTRY_SIZE, sizeof(struct bug_entry));
> 
> ---
> base-commit: 0161bd38c24312853ed5ae9a425a1c41c4ac674a
> change-id: 20241113-vdso-powerpc-asm-offsets-056016f80174
> 
> Best regards,

Re: [PATCH] powerpc/vdso: Remove unused clockmode asm offsets

[Michael Ellerman]

On Wed, 13 Nov 2024 09:06:58 +0100, Thomas Weißschuh wrote:
> These offsets are not used anymore, delete them.
> 
> 

Applied to powerpc/next.

[1/1] powerpc/vdso: Remove unused clockmode asm offsets
      https://git.kernel.org/powerpc/c/d7a82238cb8c77d4ed8cc97cd556c5f3e64bc749

cheers

Re: [PATCH] powerpc/vdso: Remove unused clockmode asm offsets

[Thomas Weißschuh]

Hi Michael,

On Sun, Nov 17, 2024 at 11:09:57PM +1100, Michael Ellerman wrote:
> On Wed, 13 Nov 2024 09:06:58 +0100, Thomas Weißschuh wrote:
> > These offsets are not used anymore, delete them.
> > 
> > 
> 
> Applied to powerpc/next.
> 
> [1/1] powerpc/vdso: Remove unused clockmode asm offsets
>       https://git.kernel.org/powerpc/c/d7a82238cb8c77d4ed8cc97cd556c5f3e64bc749

Thanks!

Is there any chance to get this merged as part of topic/vdso?
My vdso rework patches for the 6.14 cycle rely on these removals.


Thomas

Re: [PATCH] powerpc/vdso: Remove unused clockmode asm offsets

[Michael Ellerman]

Thomas Weißschuh <thomas.weissschuh@linutronix.de> writes:
> Hi Michael,
>
> On Sun, Nov 17, 2024 at 11:09:57PM +1100, Michael Ellerman wrote:
>> On Wed, 13 Nov 2024 09:06:58 +0100, Thomas Weißschuh wrote:
>> > These offsets are not used anymore, delete them.
>> > 
>> > 
>> 
>> Applied to powerpc/next.
>> 
>> [1/1] powerpc/vdso: Remove unused clockmode asm offsets
>>       https://git.kernel.org/powerpc/c/d7a82238cb8c77d4ed8cc97cd556c5f3e64bc749
>
> Thanks!
>
> Is there any chance to get this merged as part of topic/vdso?
 
I could apply it there, but I don't think it will be necessary, because
topic/vdso will be empty vs mainline as soon as I send my pull request
for v6.13.

> My vdso rework patches for the 6.14 cycle rely on these removals.

Assuming you rebase that series onto v6.13-rc1 or later, this commit
will be included in that base.

But let me know if I'm misunderstanding something.

cheers

Re: [PATCH] powerpc/vdso: Remove unused clockmode asm offsets

[Thomas Weißschuh]

On Tue, Nov 19, 2024 at 02:26:22PM +1100, Michael Ellerman wrote:
> Thomas Weißschuh <thomas.weissschuh@linutronix.de> writes:
> > Hi Michael,
> >
> > On Sun, Nov 17, 2024 at 11:09:57PM +1100, Michael Ellerman wrote:
> >> On Wed, 13 Nov 2024 09:06:58 +0100, Thomas Weißschuh wrote:
> >> > These offsets are not used anymore, delete them.
> >> > 
> >> > 
> >> 
> >> Applied to powerpc/next.
> >> 
> >> [1/1] powerpc/vdso: Remove unused clockmode asm offsets
> >>       https://git.kernel.org/powerpc/c/d7a82238cb8c77d4ed8cc97cd556c5f3e64bc749
> >
> > Thanks!
> >
> > Is there any chance to get this merged as part of topic/vdso?
>  
> I could apply it there, but I don't think it will be necessary, because
> topic/vdso will be empty vs mainline as soon as I send my pull request
> for v6.13.

Ah, I assumed the generic next branch wouldn't make it into 6.13 this
late in the cycle.

> > My vdso rework patches for the 6.14 cycle rely on these removals.
> 
> Assuming you rebase that series onto v6.13-rc1 or later, this commit
> will be included in that base.

Great, thanks!

> But let me know if I'm misunderstanding something.


Thanks,
Thomas