From: Michael Ellerman <mpe@ellerman.id.au>
To: Shrikanth Hegde <sshegde@linux.ibm.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com,
maddy@linux.ibm.com, christophe.leroy@csgroup.eu,
peterz@infradead.org, ankur.a.arora@oracle.com
Subject: Re: [PATCH] powerpc: Add preempt lazy support
Date: Thu, 14 Nov 2024 13:01:29 +1100 [thread overview]
Message-ID: <877c96vaiu.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <054a79d6-85a4-4c02-a361-d8e4b34ca674@linux.ibm.com>
Shrikanth Hegde <sshegde@linux.ibm.com> writes:
> Thank you Sebastian for taking a look and rwb tag.
>
>> On 2024-11-08 15:48:53 [+0530], Shrikanth Hegde wrote:
>>> Define preempt lazy bit for Powerpc. Use bit 9 which is free and within
>>> 16 bit range of NEED_RESCHED, so compiler can issue single andi.
>>>
>>> Since Powerpc doesn't use the generic entry/exit, add lazy check at exit
>>> to user. CONFIG_PREEMPTION is defined for lazy/full/rt so use it for
>>> return to kernel.
>>>
>>> Ran a few benchmarks and db workload on Power10. Performance is close to
>>> preempt=none/voluntary. It is possible that some patterns would
>>> differ in lazy[2]. More details of preempt lazy is here [1]
>>>
>>> Since Powerpc system can have large core count and large memory,
>>> preempt lazy is going to be helpful in avoiding soft lockup issues.
>>>
>>> [1]: https://lore.kernel.org/lkml/20241007074609.447006177@infradead.org/
>>> [2]: https://lore.kernel.org/all/1a973dda-c79e-4d95-935b-e4b93eb077b8@linux.ibm.com/
>>
>> The lazy bits are only in tip.
>
> Hi Michael, I sent it to powerpc tree since all the changes were in
> arch/powerpc. Please let me know if i have send it to tip tree instead.
I think I'd like it to have a full cycle of testing in next before going
into mainline. So I'll plan to take this via the powerpc tree for the
next cycle.
I assume you haven't tested 32-bit at all?
cheers
next prev parent reply other threads:[~2024-11-14 2:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 10:18 [PATCH] powerpc: Add preempt lazy support Shrikanth Hegde
2024-11-08 10:50 ` Sebastian Andrzej Siewior
2024-11-09 16:52 ` Shrikanth Hegde
2024-11-14 2:01 ` Michael Ellerman [this message]
2024-11-15 7:04 ` Shrikanth Hegde
2024-11-08 19:06 ` Ankur Arora
2024-11-09 16:54 ` Shrikanth Hegde
2024-11-15 7:19 ` Shrikanth Hegde
2024-11-15 21:32 ` Ankur Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c96vaiu.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=ankur.a.arora@oracle.com \
--cc=bigeasy@linutronix.de \
--cc=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).