linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Luming Yu <luming.yu@shingroup.cn>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	mpe@ellerman.id.au, npiggin@gmail.com,
	christophe.leroy@csgroup.eu, luming.yu@gmail.com
Cc: Luming Yu <luming.yu@shingroup.cn>
Subject: Re: [PATCH v2 5/8] powerpc/entry: add irqentry_state and generic entry support
Date: Wed, 13 Nov 2024 07:41:26 +0100	[thread overview]
Message-ID: <877c97my95.ffs@tglx> (raw)
In-Reply-To: <B8D89E4E26FBB584+20241111031934.1579-10-luming.yu@shingroup.cn>

On Mon, Nov 11 2024 at 11:19, Luming Yu wrote:
> generic irq entry support via generic irqentry is added for powerpc.
> There may be duplciate calls and missing callbacks requires further
> work.

No. This needs to be a transition which is consistent and correct at any
stage of the series.

You cannot go and break stuff first and then gradually add hacks to fix
it up. Well, you can but don't be surprised if it goes nowhere.

Thanks,

        tglx






  reply	other threads:[~2024-11-13  6:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20241111031934.1579-2-luming.yu@shingroup.cn>
2024-11-11  3:19 ` [PATCH v2 2/8] powerpc/entry: cleanup syscall entry Luming Yu
2024-11-13  6:52   ` Thomas Gleixner
2024-11-11  3:19 ` [PATCH v2 3/8] powerpc/debug: implement HAVE_USER_RETURN_NOTIFIER Luming Yu
2024-11-13  6:48   ` Thomas Gleixner
2024-11-11  3:19 ` [PATCH v2 4/8] powerpc/debug: hook to user return notifier infrastructure Luming Yu
2024-11-11  3:19 ` [PATCH v2 5/8] powerpc/entry: add irqentry_state and generic entry support Luming Yu
2024-11-13  6:41   ` Thomas Gleixner [this message]
2024-11-11  3:19 ` [PATCH v2 6/8] powerpc/entry: factout irqentry-state Luming Yu
2024-11-13  6:32   ` Thomas Gleixner
2024-11-11  3:19 ` [PATCH v2 7/8] powerpc/entry: fix 32bit compile issue for common entry Luming Yu
2024-11-11  3:19 ` [PATCH v2 8/8] powerpc/entry: fix ppc syscall entry issues " Luming Yu
2024-11-13  7:06   ` Thomas Gleixner
2024-11-13  8:19     ` Luming Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877c97my95.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luming.yu@gmail.com \
    --cc=luming.yu@shingroup.cn \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).