From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D64E7CDB47E for ; Fri, 20 Oct 2023 10:45:13 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=ifl/oYvh; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SBh7D3mcMz3cgf for ; Fri, 20 Oct 2023 21:45:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=ifl/oYvh; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SBh6G2glwz30P0 for ; Fri, 20 Oct 2023 21:44:22 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1697798659; bh=BOQy2S+gkRQ6GqEG1l3wx7Pc1XFdYna8OiPHPqKzES4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ifl/oYvh+TRsSqRgEPMixGOqr4MoU0N6idL02NbzyNh9SF3hMbCT+41P1QDWt9mVo r0TnbRSCGpHxnFA9gfGRPjgqC0x+mJUC+G5G3bjzrS2ECDmKQriQsQBsa5eSkJrlLT nIqcKEqedWmBVS5HNXbL1uOSBHiHHvVSm1LE7Kg0f1/pSXNmJVbpWAnvbch0WWD0+u Z0dVWmEId377e1yEOsZALaWYmd8CxmAeINvjgQIdioHEWLBHybz/2wsXn2p1O86dEd SGlFy6Qr3r8lxy7s+ZxRnYq6QqQnhT34XhJPgr0BVQ0hdxxZZmMskpbccxYulBee/c Cwb6zW0meP0UQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SBh6B6KH4z4xdP; Fri, 20 Oct 2023 21:44:18 +1100 (AEDT) From: Michael Ellerman To: Srikar Dronamraju Subject: Re: [PATCH v2 3/6] powerpc/smp: Move shared_processor static key to smp.h In-Reply-To: <20231019130843.GI2194132@linux.vnet.ibm.com> References: <20231018163751.2423181-1-srikar@linux.vnet.ibm.com> <20231018163751.2423181-4-srikar@linux.vnet.ibm.com> <87sf675im3.fsf@mail.lhotse> <20231019130843.GI2194132@linux.vnet.ibm.com> Date: Fri, 20 Oct 2023 21:44:14 +1100 Message-ID: <877cnh60ap.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Valentin Schneider , Peter Zijlstra , linux-kernel@vger.kernel.org, x86@kernel.org, Ajay Kaher , Nicholas Piggin , virtualization@lists.linux-foundation.org, VMware PV-Drivers Reviewers , Rohan McLure , Alexey Makhalov , linuxppc-dev , Josh Poimboeuf Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Srikar Dronamraju writes: > * Michael Ellerman [2023-10-19 15:41:40]: > >> Srikar Dronamraju writes: >> > The ability to detect if the system is running in a shared processor >> > mode is helpful in few more generic cases not just in >> > paravirtualization. >> > For example: At boot time, different scheduler/ topology flags may be >> > set based on the processor mode. Hence move it to a more generic file. >> >> I'd rather you just included paravirt.h in the few files where you need it. > > I thought, detecting if a Processor was shared or not was more a > smp/processor related than a paravirt related. It's both really :) It's definitely paravirt related though, because if we weren't *para*virt then we wouldn't know there was a hypervisor at all :) But having smaller more focused headers is preferable in general just for mechanical reasons. cheers