From: Michael Ellerman <mpe@ellerman.id.au>
To: Olof Johansson <olof@lixom.net>,
Christian Zigotzky <chzigotzky@xenosoft.de>
Cc: Darren Stevens <darren@stevens-zone.net>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"R.T.Dickinson" <rtd2@xtra.co.nz>
Subject: Re: [PASEMI] Nemo board doesn't boot anymore because of moving pas_pci_init
Date: Wed, 24 Feb 2021 11:55:00 +1100 [thread overview]
Message-ID: <877dmythcr.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <CAOesGMgtAXPQRThhkF5QR25R+F68F5C_HSUvFPW0Wk1DcpCwvA@mail.gmail.com>
Olof Johansson <olof@lixom.net> writes:
> Hi,
>
> On Tue, Feb 23, 2021 at 1:43 PM Christian Zigotzky
> <chzigotzky@xenosoft.de> wrote:
>>
>> Hello,
>>
>> The Nemo board [1] with a P.A. Semi PA6T SoC doesn't boot anymore
>> because of moving "pas_pci_init" to the device tree adoption [2] in the
>> latest PowerPC updates 5.12-1 [3].
>>
>> Unfortunately the Nemo board doesn't have it in its device tree. I
>> reverted this commit and after that the Nemo board boots without any
>> problems.
>>
>> What do you think about this ifdef?
>>
>> #ifdef CONFIG_PPC_PASEMI_NEMO
>> /*
>> * Check for the Nemo motherboard here, if we are running on one
>> * then pas_pci_init()
>> */
>> if (of_machine_is_compatible("pasemi,nemo")) {
>> pas_pci_init();
>> }
>> #endif
>
> This is not a proper fix for the problem. Someone will need to debug
> what on the pas_pci_init() codepath still needs to happen early in the
> boot, even if the main PCI setup happens later.
I looked but don't see anything 100% obvious.
Possibly it's the call to isa_bridge_find_early()?
static int __init pas_add_bridge(struct device_node *dev)
{
...
/*
* Scan for an isa bridge. This is needed to find the SB600 on the nemo
* and does nothing on machines without one.
*/
isa_bridge_find_early(hose);
return 0;
}
cheers
next prev parent reply other threads:[~2021-02-24 0:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 21:43 [PASEMI] Nemo board doesn't boot anymore because of moving pas_pci_init Christian Zigotzky
2021-02-23 22:28 ` Olof Johansson
2021-02-24 0:55 ` Michael Ellerman [this message]
2021-02-24 2:17 ` Oliver O'Halloran
2021-02-24 12:15 ` Christian Zigotzky
2021-02-26 12:34 ` Latest Git kernel doesn't compile because of the LINUX_VERSION_CODE issue Christian Zigotzky
2021-02-26 16:10 ` Christophe Leroy
2021-02-27 7:13 ` Christian Zigotzky
2021-02-27 7:34 ` Christophe Leroy
2021-02-27 15:42 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dmythcr.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=olof@lixom.net \
--cc=rtd2@xtra.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).