From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
"kvm@vger.kernel.org mailing list" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: PPC: Use schedule instead of cond_resched
Date: Tue, 10 Dec 2013 21:38:14 +0530 [thread overview]
Message-ID: <877gbcsn81.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <C3F93DB3-202A-427D-A7B6-A868F3743507@suse.de>
Alexander Graf <agraf@suse.de> writes:
> On 10.12.2013, at 15:21, Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> wrote:
>
>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>>
>> We already checked need_resched. So we can call schedule directly
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> The real fix for the issue you're seeing is
>
> https://lkml.org/lkml/2013/11/28/241
True, I mentioned that in the thread
https://lkml.org/lkml/2013/12/9/64
But do we need to do cond_resched after we checked for need_resched() ?
-aneesh
next prev parent reply other threads:[~2013-12-11 2:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 14:21 [PATCH] KVM: PPC: Use schedule instead of cond_resched Aneesh Kumar K.V
2013-12-10 14:40 ` Alexander Graf
2013-12-10 16:08 ` Aneesh Kumar K.V [this message]
2013-12-10 17:00 ` Alexander Graf
2013-12-10 20:52 ` Benjamin Herrenschmidt
2013-12-10 22:48 ` Peter Zijlstra
2013-12-10 22:59 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gbcsn81.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).