linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Peter Korsgaard" <jacmet@sunsite.dk>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Karol Gugala" <kgugala@antmicro.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	linux-samsung-soc@vger.kernel.org,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
	"Hammer Hsieh" <hammerh0314@gmail.com>,
	"Jiamei Xie" <jiamei.xie@arm.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Vineet Gupta" <vgupta@kernel.org>,
	"Thierry Reding" <treding@nvidia.com>,
	"Petr Mladek" <pmladek@suse.com>,
	"Arend van Spriel" <arend.vanspriel@broadcom.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	linux-unisoc@lists.infradead.org,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Richard Genoud" <richard.genoud@gmail.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	linux-aspeed@lists.ozlabs.org,
	"Laxman Dewangan" <ldewangan@nvidia.com>,
	"Dmitry Rokosov" <ddrokosov@sberdevices.ru>,
	"Xiongfeng Wang" <wangxiongfeng2@huawei.com>,
	"Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>,
	delisun <delisun@pateo.com.cn>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Ruan Jinjie" <ruanjinjie@huawei.com>,
	"Matthew Howell" <matthew.howell@sealevel.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Gabriel Somlo" <gsomlo@gmail.com>,
	"Hongyu Xie" <xiehongyu1@kylinos.cn>,
	"Tobias Klauser" <tklauser@distanz.ch>,
	"Yangtao Li" <frank.li@vivo.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	linux-arm-msm@vger.kernel.org, linux-actions@lists.infradead.org,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	linux-amlogic@lists.infradead.org,
	"Michal Simek" <michal.simek@amd.com>,
	"Sherry Sun" <sherry.sun@nxp.com>
Subject: Re: [PATCH tty v1 00/74] serial: wrappers for uart port lock
Date: Sat, 16 Sep 2023 21:48:14 +0206	[thread overview]
Message-ID: <878r95nbvt.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <1446dc6-5ab0-629-45c8-3b7d8c76367d@linux.intel.com>

On 2023-09-15, Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:
> Would this also be useful to enable printing to console while under
> port's lock (by postponing the output until the lock is released)?
>
> E.g., 8250_dw.c has had this commented out since the dawn on time:
>         /*
>          * FIXME: this deadlocks if port->lock is already held
>          * dev_err(p->dev, "Couldn't set LCR to %d\n", value);
>          */

Yes, this will fix such issues. However, only for consoles that are
converted to the new NBCON console type.

Good news, the 8250 driver will be the flagship driver that is converted
as part of the rework. So this particular issue will be solved then. I
will try to remember this so that I can remove the FIXME in the series.

Thanks for mentioning it.

John

  reply	other threads:[~2023-09-16 23:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 18:37 [PATCH tty v1 00/74] serial: wrappers for uart port lock John Ogness
2023-09-14 18:38 ` [PATCH tty v1 47/74] serial: pmac_zilog: Use port lock wrappers John Ogness
2023-09-14 18:38 ` [PATCH tty v1 72/74] serial: ucc_uart: " John Ogness
2023-09-15 15:06   ` Timur Tabi
2023-09-14 19:01 ` [PATCH tty v1 00/74] serial: wrappers for uart port lock Maciej W. Rozycki
2023-09-15 12:04   ` Thomas Gleixner
2023-09-15 17:23     ` Maciej W. Rozycki
2023-09-16 19:24       ` John Ogness
2023-09-15  9:12 ` Ilpo Järvinen
2023-09-16 19:42   ` John Ogness [this message]
2023-09-18  8:23 ` John Ogness
2023-09-18  8:26   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r95nbvt.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andrew@aj.id.au \
    --cc=arend.vanspriel@broadcom.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=ddrokosov@sberdevices.ru \
    --cc=delisun@pateo.com.cn \
    --cc=festevam@gmail.com \
    --cc=frank.li@vivo.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=gsomlo@gmail.com \
    --cc=hammerh0314@gmail.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jacmet@sunsite.dk \
    --cc=jbrunet@baylibre.com \
    --cc=jiamei.xie@arm.com \
    --cc=jonathanh@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=kgugala@antmicro.com \
    --cc=khilman@baylibre.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-unisoc@lists.infradead.org \
    --cc=macro@orcam.me.uk \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=matthew.howell@sealevel.com \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=michal.simek@amd.com \
    --cc=npiggin@gmail.com \
    --cc=pmladek@suse.com \
    --cc=richard.genoud@gmail.com \
    --cc=ruanjinjie@huawei.com \
    --cc=s.hauer@pengutronix.de \
    --cc=samuel.holland@sifive.com \
    --cc=sherry.sun@nxp.com \
    --cc=tglx@linutronix.de \
    --cc=tklauser@distanz.ch \
    --cc=treding@nvidia.com \
    --cc=vgupta@kernel.org \
    --cc=wangxiongfeng2@huawei.com \
    --cc=xiehongyu1@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).