From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
christophe leroy <christophe.leroy@c-s.fr>,
benh@kernel.crashing.org, paulus@samba.org
Cc: Scott Wood <oss@buserror.net>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] powerpc/mm/hugetlb: Add support for reserving gigantic huge pages via kernel command line
Date: Mon, 05 Jun 2017 13:17:55 +0530 [thread overview]
Message-ID: <878tl63mfo.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <87bmq72irn.fsf@concordia.ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> writes:
> Tyrel Datwyler <tyreld@linux.vnet.ibm.com> writes:
>> On 06/01/2017 09:42 AM, christophe leroy wrote:
>>> Le 01/06/2017 =C3=A0 16:30, Aneesh Kumar K.V a =C3=A9crit :
>>>> diff --git a/arch/powerpc/include/asm/book3s/64/mmu-hash.h b/arch/powe=
rpc/include/asm/book3s/64/mmu-hash.h
>>>> index 6981a52b3887..67766e60a6b6 100644
>>>> --- a/arch/powerpc/include/asm/book3s/64/mmu-hash.h
>>>> +++ b/arch/powerpc/include/asm/book3s/64/mmu-hash.h
>>>> @@ -468,7 +468,7 @@ extern int htab_bolt_mapping(unsigned long vstart,=
unsigned long vend,
>>>> int psize, int ssize);
>>>> int htab_remove_mapping(unsigned long vstart, unsigned long vend,
>>>> int psize, int ssize);
>>>> -extern void add_gpage(u64 addr, u64 page_size, unsigned long number_o=
f_pages);
>>>> +extern void pSeries_add_gpage(u64 addr, u64 page_size, unsigned long =
number_of_pages);
>>>=20
>>> Linux kernel coding style says 'mixed-case names are frowned upon'
>>
>> True, but there is precedent within arch/powerpc/platforms/pseries seein=
g as "pSeries_" is
>> already used heavily to prefix function names.
>
> True, but it's still horrible. Any new names should just use "pseries".
I will update in the next iteration. I will wait to get feedback on
FSL/8xx before posting the next version.
-aneesh
next prev parent reply other threads:[~2017-06-05 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 14:30 [PATCH v2 1/2] mm/hugetlb: Allow arch to override and call the weak function Aneesh Kumar K.V
2017-06-01 14:30 ` [PATCH v2 2/2] powerpc/mm/hugetlb: Add support for reserving gigantic huge pages via kernel command line Aneesh Kumar K.V
2017-06-01 16:42 ` christophe leroy
2017-06-01 19:11 ` Tyrel Datwyler
2017-06-02 3:03 ` Michael Ellerman
2017-06-05 7:47 ` Aneesh Kumar K.V [this message]
2017-06-05 7:47 ` Aneesh Kumar K.V
2017-06-09 16:13 ` Christophe LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tl63mfo.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).