From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rlJjG4mBTzDr0j for ; Thu, 7 Jul 2016 10:41:54 +1000 (AEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u670XYI3111066 for ; Wed, 6 Jul 2016 20:41:52 -0400 Received: from e24smtp02.br.ibm.com (e24smtp02.br.ibm.com [32.104.18.86]) by mx0a-001b2d01.pphosted.com with ESMTP id 2415xj5fds-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 06 Jul 2016 20:41:52 -0400 Received: from localhost by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Jul 2016 21:41:49 -0300 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id D6834352005F for ; Wed, 6 Jul 2016 20:41:29 -0400 (EDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91]) by d24relay01.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u670flRL4776154 for ; Wed, 6 Jul 2016 21:41:47 -0300 Received: from d24av01.br.ibm.com (localhost [127.0.0.1]) by d24av01.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u670fk88015329 for ; Wed, 6 Jul 2016 21:41:47 -0300 From: Gabriel Krisman Bertazi To: Mauricio Faria de Oliveira Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Jens Axboe , Jonathan Corbet , Benjamin Herrenschmidt , Keith Busch , Michael Ellerman , Russell King , Andrew Morton Subject: Re: [PATCH 2/3] nvme: implement DMA_ATTR_NO_WARN References: <1467839013-22481-1-git-send-email-mauricfo@linux.vnet.ibm.com> <1467839013-22481-3-git-send-email-mauricfo@linux.vnet.ibm.com> Date: Wed, 06 Jul 2016 21:41:45 -0300 In-Reply-To: <1467839013-22481-3-git-send-email-mauricfo@linux.vnet.ibm.com> (Mauricio Faria de Oliveira's message of "Wed, 6 Jul 2016 18:03:32 -0300") MIME-Version: 1.0 Content-Type: text/plain Message-Id: <878txep9di.fsf@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mauricio Faria de Oliveira writes: > Use the DMA_ATTR_NO_WARN attribute on dma_map_sg() calls of nvme driver. > > Signed-off-by: Mauricio Faria de Oliveira checkpatch.pl complains about line wrapping. Other than that, this looks good to me. Reviewed-by: Gabriel Krisman Bertazi > --- > drivers/nvme/host/pci.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index d1a8259..c3c3348 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -65,6 +66,8 @@ MODULE_PARM_DESC(use_cmb_sqes, "use controller's memory buffer for I/O SQes"); > > static struct workqueue_struct *nvme_workq; > > +static DEFINE_DMA_ATTRS(nvme_dma_attrs); > + > struct nvme_dev; > struct nvme_queue; > > @@ -498,7 +501,7 @@ static int nvme_map_data(struct nvme_dev *dev, struct request *req, > goto out; > > ret = BLK_MQ_RQ_QUEUE_BUSY; > - if (!dma_map_sg(dev->dev, iod->sg, iod->nents, dma_dir)) > + if (!dma_map_sg_attrs(dev->dev, iod->sg, iod->nents, dma_dir, &nvme_dma_attrs)) > goto out; > > if (!nvme_setup_prps(dev, req, size)) > @@ -516,7 +519,7 @@ static int nvme_map_data(struct nvme_dev *dev, struct request *req, > if (rq_data_dir(req)) > nvme_dif_remap(req, nvme_dif_prep); > > - if (!dma_map_sg(dev->dev, &iod->meta_sg, 1, dma_dir)) > + if (!dma_map_sg_attrs(dev->dev, &iod->meta_sg, 1, dma_dir, &nvme_dma_attrs)) > goto out_unmap; > } > > @@ -2118,6 +2121,9 @@ static int __init nvme_init(void) > result = pci_register_driver(&nvme_driver); > if (result) > destroy_workqueue(nvme_workq); > + > + dma_set_attr(DMA_ATTR_NO_WARN, &nvme_dma_attrs); > + > return result; > } -- Gabriel Krisman Bertazi