linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Axtens <dja@axtens.net>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: "Geyslan G. Bem" <geyslan@gmail.com>,
	kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>,
	linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
	Paul Mackerras <paulus@samba.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	linuxppc-dev@lists.ozlabs.org, Alexander Graf <agraf@suse.com>
Subject: Re: [PATCH] kvm: remove unused variable 'vcpu_book3s'
Date: Wed, 02 Dec 2015 11:34:21 +1100	[thread overview]
Message-ID: <878u5dk7si.fsf@gamma.ozlabs.ibm.com> (raw)
In-Reply-To: <1449013410-19103-1-git-send-email-geyslan@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

"Geyslan G. Bem" <geyslan@gmail.com> writes:

> The vcpu_book3s struct is assigned but never used. So remove it.

Just out of interest, how did you find this? Compiler warning? Static
analysis? Manual inspection?

Thanks in advance!

Regards,
Daniel

>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
>  arch/powerpc/kvm/book3s_64_mmu.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu.c b/arch/powerpc/kvm/book3s_64_mmu.c
> index 774a253..9bf7031 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu.c
> @@ -377,15 +377,12 @@ no_seg_found:
>  
>  static void kvmppc_mmu_book3s_64_slbmte(struct kvm_vcpu *vcpu, u64 rs, u64 rb)
>  {
> -	struct kvmppc_vcpu_book3s *vcpu_book3s;
>  	u64 esid, esid_1t;
>  	int slb_nr;
>  	struct kvmppc_slb *slbe;
>  
>  	dprintk("KVM MMU: slbmte(0x%llx, 0x%llx)\n", rs, rb);
>  
> -	vcpu_book3s = to_book3s(vcpu);
> -
>  	esid = GET_ESID(rb);
>  	esid_1t = GET_ESID_1T(rb);
>  	slb_nr = rb & 0xfff;
> -- 
> 2.6.2
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 859 bytes --]

  reply	other threads:[~2015-12-02  0:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 23:42 [PATCH] kvm: remove unused variable 'vcpu_book3s' Geyslan G. Bem
2015-12-02  0:34 ` Daniel Axtens [this message]
2015-12-02  1:11   ` Geyslan G. Bem
2015-12-10  0:39 ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878u5dk7si.fsf@gamma.ozlabs.ibm.com \
    --to=dja@axtens.net \
    --cc=agraf@suse.com \
    --cc=geyslan@gmail.com \
    --cc=gleb@kernel.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).