public inbox for linuxppc-dev@ozlabs.org
 help / color / mirror / Atom feed
From: Venkat <venkat88@linux.ibm.com>
To: Srish Srinivasan <ssrish@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com,
	mpe@ellerman.id.au, npiggin@gmail.com,
	christophe.leroy@csgroup.eu, nayna@linux.ibm.com,
	zohar@linux.ibm.com, rnsastry@linux.ibm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/pseries: plpks: export plpks_wrapping_is_supported
Date: Fri, 6 Feb 2026 20:13:22 +0530	[thread overview]
Message-ID: <8798DBE0-4A30-44E8-9DAA-39F5BB896286@linux.ibm.com> (raw)
In-Reply-To: <20260201165344.950870-1-ssrish@linux.ibm.com>



> On 1 Feb 2026, at 10:23 PM, Srish Srinivasan <ssrish@linux.ibm.com> wrote:
> 
> Building trusted-keys as a module fails modpost with:
> 
> ERROR: modpost: "plpks_wrapping_is_supported" [security/keys/trusted-keys/
> trusted.ko] undefined!
> 
> Export plpks_wrapping_is_supported() so trusted-keys links cleanly
> 
> This patch is intended to be applied on top of the earlier "Extend "trusted
> " keys to support a new trust source named the PowerVM Key Wrapping Module
> (PKWM)" series (v5).
> Link: https://lore.kernel.org/all/20260127145228.48320-1-ssrish@linux.ibm.com/
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202602010724.1g9hbLKv-lkp@intel.com/
> Signed-off-by: Srish Srinivasan <ssrish@linux.ibm.com>
> ---
> arch/powerpc/platforms/pseries/plpks.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
> index 038ecf8f6d6b..23e4e2a922fc 100644
> --- a/arch/powerpc/platforms/pseries/plpks.c
> +++ b/arch/powerpc/platforms/pseries/plpks.c
> @@ -896,6 +896,7 @@ bool plpks_wrapping_is_supported(void)
> {
> return wrapsupport;
> }
> +EXPORT_SYMBOL_GPL(plpks_wrapping_is_supported);
> 
> /**
>  * plpks_gen_wrapping_key() - Generate a new random key with the 'wrapping key'
> -- 
> 2.47.3
> 

Tested this patch, and with this, build is successful.

With out this patch:

ERROR: modpost: "plpks_wrapping_is_supported" [security/keys/trusted-keys/trusted.ko] undefined!
make[2]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1
make[1]: *** [/root/linux/Makefile:2004: modpost] Error 2
make: *** [Makefile:248: __sub-make] Error 2

With this build is successful.

Please add below tag.

Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>

Regards,
Venkat.



      reply	other threads:[~2026-02-06 14:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-01 16:53 [PATCH] powerpc/pseries: plpks: export plpks_wrapping_is_supported Srish Srinivasan
2026-02-06 14:43 ` Venkat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8798DBE0-4A30-44E8-9DAA-39F5BB896286@linux.ibm.com \
    --to=venkat88@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=nayna@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=rnsastry@linux.ibm.com \
    --cc=ssrish@linux.ibm.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox