From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 759D2C43334 for ; Tue, 21 Jun 2022 14:46:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LS8TT6s1Dz3cdL for ; Wed, 22 Jun 2022 00:46:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=KX1TC+jI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=nathanl@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=KX1TC+jI; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LS8Sh3V82z30BP for ; Wed, 22 Jun 2022 00:45:23 +1000 (AEST) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25LEge2R014696; Tue, 21 Jun 2022 14:45:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=rlGp1ZBr5LIPClzBnWZoPVjow12ra4Wnniyl0HfZFbs=; b=KX1TC+jIqWVh7KjIdbJoob6NpoDeY0s9yKr7+GwYA94mDHxY/1RU4CB5QF5VINdqd0Tq 3U5rCDG7rwycbDGuPHhy/ZKqM1wAioXptSDh/ov/TJHct7Ura5fudZrHCpLWFzCFIECt SFlWYTG47tEtC/5/luhJ1IeLjPhbHg0iZXn5PpvbcnwZHU2cwUDLB0rO8a1zeUPqqk8L ZEdinM5cbZNSAvoaaAYp59wln+VRpN2oMxMfnV40H0hMIriRAgMcY7oAfZysgJYf+xwG JQJp443gwL5Tfer7qHh9DIuhM/hVa2+HSEzXI67zEXXgMrPT9fviWx+RRF2Ph+QLar63 0Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gug0002ak-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 14:45:18 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 25LEi53l031786; Tue, 21 Jun 2022 14:45:17 GMT Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gug00029q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 14:45:17 +0000 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25LELERf025260; Tue, 21 Jun 2022 14:45:16 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma05wdc.us.ibm.com with ESMTP id 3gs6b9chyt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jun 2022 14:45:16 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25LEjF6610289572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jun 2022 14:45:15 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 86661AE063; Tue, 21 Jun 2022 14:45:15 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3F2CFAE064; Tue, 21 Jun 2022 14:45:15 +0000 (GMT) Received: from localhost (unknown [9.211.80.5]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 21 Jun 2022 14:45:15 +0000 (GMT) From: Nathan Lynch To: Scott Cheloha , linux-watchdog@vger.kernel.org Subject: Re: [PATCH v2 1/4] powerpc/pseries: hvcall.h: add H_WATCHDOG opcode, H_NOOP return code In-Reply-To: <20220602175353.68942-2-cheloha@linux.ibm.com> References: <20220602175353.68942-1-cheloha@linux.ibm.com> <20220602175353.68942-2-cheloha@linux.ibm.com> Date: Tue, 21 Jun 2022 09:44:42 -0500 Message-ID: <87a6a6nkit.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: agk8Z1kgyynumTunF44NsQkaUBsXoeQw X-Proofpoint-GUID: gQfKKbBC3cJbBd4HbZFFpAviflnxmDlh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-21_07,2022-06-21_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1011 mlxlogscore=999 impostorscore=0 adultscore=0 priorityscore=1501 mlxscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206210062 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wvoigt@us.ibm.com, aik@ozlabs.ru, Scott Cheloha , vaishnavi@linux.ibm.com, npiggin@gmail.com, tzungbi@kernel.org, brking@linux.ibm.com, linuxppc-dev@lists.ozlabs.org, linux@roeck-us.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Scott Cheloha writes: > PAPR v2.12 defines a new hypercall, H_WATCHDOG. The hypercall permits > guest control of one or more virtual watchdog timers. > > Add the opcode for the H_WATCHDOG hypercall to hvcall.h. While here, > add a definition for H_NOOP, a possible return code for H_WATCHDOG. > > Signed-off-by: Scott Cheloha > --- > arch/powerpc/include/asm/hvcall.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h > index d92a20a85395..4b4f69c35b4f 100644 > --- a/arch/powerpc/include/asm/hvcall.h > +++ b/arch/powerpc/include/asm/hvcall.h > @@ -87,6 +87,7 @@ > #define H_P7 -60 > #define H_P8 -61 > #define H_P9 -62 > +#define H_NOOP -63 > #define H_TOO_BIG -64 > #define H_UNSUPPORTED -67 > #define H_OVERLAP -68 Not a problem to fix in your series, but I guess these should be parenthesized i.e. #define H_P7 (-60) #define H_P8 (-61) #define H_P9 (-62) #define H_NOOP (-63) > @@ -324,7 +325,8 @@ > #define H_RPT_INVALIDATE 0x448 > #define H_SCM_FLUSH 0x44C > #define H_GET_ENERGY_SCALE_INFO 0x450 > -#define MAX_HCALL_OPCODE H_GET_ENERGY_SCALE_INFO > +#define H_WATCHDOG 0x45C > +#define MAX_HCALL_OPCODE H_WATCHDOG > Looks fine. Reviewed-by: Nathan Lynch