* [PATCH] powerpc/xive: Update comment referencing magic loads from an ESB
@ 2019-08-02 0:08 Jordan Niethe
2019-08-02 0:22 ` Stewart Smith
2019-08-10 10:20 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Jordan Niethe @ 2019-08-02 0:08 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Jordan Niethe
The comment above xive_esb_read() references magic loads from an ESB as
described xive.h. This has been inaccurate since commit 12c1f339cd49
("powerpc/xive: Move definition of ESB bits") which moved the
description. Update the comment to reference the new location of the
description in xive-regs.h
Signed-off-by: Jordan Niethe <jniethe5@gmail.com>
---
arch/powerpc/sysdev/xive/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
index 1cdb39575eae..083f657091d7 100644
--- a/arch/powerpc/sysdev/xive/common.c
+++ b/arch/powerpc/sysdev/xive/common.c
@@ -185,7 +185,7 @@ static u32 xive_scan_interrupts(struct xive_cpu *xc, bool just_peek)
/*
* This is used to perform the magic loads from an ESB
- * described in xive.h
+ * described in xive-regs.h
*/
static notrace u8 xive_esb_read(struct xive_irq_data *xd, u32 offset)
{
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/xive: Update comment referencing magic loads from an ESB 2019-08-02 0:08 [PATCH] powerpc/xive: Update comment referencing magic loads from an ESB Jordan Niethe @ 2019-08-02 0:22 ` Stewart Smith 2019-08-10 10:20 ` Michael Ellerman 1 sibling, 0 replies; 3+ messages in thread From: Stewart Smith @ 2019-08-02 0:22 UTC (permalink / raw) To: Jordan Niethe, linuxppc-dev; +Cc: Jordan Niethe Jordan Niethe <jniethe5@gmail.com> writes: > The comment above xive_esb_read() references magic loads from an ESB as > described xive.h. This has been inaccurate since commit 12c1f339cd49 > ("powerpc/xive: Move definition of ESB bits") which moved the > description. Update the comment to reference the new location of the > description in xive-regs.h > > Signed-off-by: Jordan Niethe <jniethe5@gmail.com> Acked-by: Stewart Smith <stewart@linux.ibm.com> -- Stewart Smith OPAL Architect, IBM. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/xive: Update comment referencing magic loads from an ESB 2019-08-02 0:08 [PATCH] powerpc/xive: Update comment referencing magic loads from an ESB Jordan Niethe 2019-08-02 0:22 ` Stewart Smith @ 2019-08-10 10:20 ` Michael Ellerman 1 sibling, 0 replies; 3+ messages in thread From: Michael Ellerman @ 2019-08-10 10:20 UTC (permalink / raw) To: Jordan Niethe, linuxppc-dev; +Cc: Jordan Niethe On Fri, 2019-08-02 at 00:08:35 UTC, Jordan Niethe wrote: > The comment above xive_esb_read() references magic loads from an ESB as > described xive.h. This has been inaccurate since commit 12c1f339cd49 > ("powerpc/xive: Move definition of ESB bits") which moved the > description. Update the comment to reference the new location of the > description in xive-regs.h > > Signed-off-by: Jordan Niethe <jniethe5@gmail.com> > Acked-by: Stewart Smith <stewart@linux.ibm.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/1ebe0dcce1750109181d666394b7dfd9af9ff645 cheers ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-10 10:29 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-08-02 0:08 [PATCH] powerpc/xive: Update comment referencing magic loads from an ESB Jordan Niethe 2019-08-02 0:22 ` Stewart Smith 2019-08-10 10:20 ` Michael Ellerman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).