From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Balbir Singh <bsingharora@gmail.com>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 1/6] powerpc/mm: update ptep_set_access_flag to not do full mm tlb flush
Date: Tue, 22 Nov 2016 11:27:19 +0530 [thread overview]
Message-ID: <87a8cshxa8.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <229327ef-bafe-75c5-79d9-2bece549ea38@gmail.com>
Balbir Singh <bsingharora@gmail.com> writes:
> On 22/11/16 05:33, Aneesh Kumar K.V wrote:
>> When we are updating pte, we just need to flush the tlb mapping for
>> that pte. Right now we do a full mm flush because we don't track page
>> size. Update the interface to track the page size and use that to
>> do the right tlb flush.
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> ---
>> arch/powerpc/include/asm/book3s/32/pgtable.h | 4 +++-
>> arch/powerpc/include/asm/book3s/64/pgtable.h | 7 +++++--
>> arch/powerpc/include/asm/book3s/64/radix.h | 14 +++++++-------
>> arch/powerpc/include/asm/nohash/32/pgtable.h | 4 +++-
>> arch/powerpc/include/asm/nohash/64/pgtable.h | 4 +++-
>> arch/powerpc/mm/pgtable-book3s64.c | 3 ++-
>> arch/powerpc/mm/pgtable-radix.c | 16 ++++++++++++++++
>> arch/powerpc/mm/pgtable.c | 10 ++++++++--
>> arch/powerpc/mm/tlb-radix.c | 15 ---------------
>> 9 files changed, 47 insertions(+), 30 deletions(-)
>>
>> diff --git a/arch/powerpc/include/asm/book3s/32/pgtable.h b/arch/powerpc/include/asm/book3s/32/pgtable.h
>> index 6b8b2d57fdc8..0713626e9189 100644
>> --- a/arch/powerpc/include/asm/book3s/32/pgtable.h
>> +++ b/arch/powerpc/include/asm/book3s/32/pgtable.h
>> @@ -224,7 +224,9 @@ static inline void huge_ptep_set_wrprotect(struct mm_struct *mm,
>>
>>
>> static inline void __ptep_set_access_flags(struct mm_struct *mm,
>> - pte_t *ptep, pte_t entry)
>> + pte_t *ptep, pte_t entry,
>> + unsigned long address,
>> + unsigned long pg_sz)
>
> I wonder if the change can be limited in scope by passing the struct vma instead
> of struct mm as the first argument and not passing pg_sz (I don't like that
> name at all, page_size if we decide to do it, please). Then extract the mm from
> vma->mm
>
https://lkml.kernel.org/r/20161114152020.4608-1-aneesh.kumar@linux.vnet.ibm.com
That patch series go on top of this series. The idea of splitting this
into two is to make it easy to backport this series if needed to older
kernels.
-aneesh
prev parent reply other threads:[~2016-11-22 5:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 18:33 [PATCH v3 1/6] powerpc/mm: update ptep_set_access_flag to not do full mm tlb flush Aneesh Kumar K.V
2016-11-21 18:33 ` [PATCH v3 2/6] powerpc/mm: Rename hugetlb-radix.h to hugetlb.h Aneesh Kumar K.V
2016-11-21 18:33 ` [PATCH v3 3/6] powerpc/mm/hugetlb: Handle hugepage size supported by hash config Aneesh Kumar K.V
2016-11-21 18:33 ` [PATCH v3 4/6] powerpc/mm/hugetlb: Switch hugetlb update to use huge_pte_update Aneesh Kumar K.V
2016-11-22 2:41 ` Michael Ellerman
2016-11-21 18:33 ` [PATCH v3 5/6] powerpc/mm: update pte_update to not do full mm tlb flush Aneesh Kumar K.V
2016-11-21 18:33 ` [PATCH v3 6/6] powerpc/mm: Batch tlb flush when invalidating pte entries Aneesh Kumar K.V
2016-11-21 20:40 ` Benjamin Herrenschmidt
2016-11-22 2:21 ` Aneesh Kumar K.V
2016-11-22 2:55 ` [PATCH v3 1/6] powerpc/mm: update ptep_set_access_flag to not do full mm tlb flush Balbir Singh
2016-11-22 5:57 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8cshxa8.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).