From: Andreas Schwab <schwab@linux-m68k.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] futex: improve user space accesses
Date: Mon, 09 Dec 2024 19:32:51 +0100 [thread overview]
Message-ID: <87bjxkzoz0.fsf@igel.home> (raw)
In-Reply-To: <CAHk-=wjnvFU3sMjjKyqtgvPe6EMu3M4f1qyZncJR5=QDQsV=ng@mail.gmail.com> (Linus Torvalds's message of "Sun, 8 Dec 2024 16:32:33 -0800")
On Dez 08 2024, Linus Torvalds wrote:
> IOW, does this one-liner fix it for you?
>
> --- a/kernel/futex/futex.h
> +++ b/kernel/futex/futex.h
> @@ -265,7 +265,7 @@
> else if (!user_read_access_begin(from, sizeof(*from)))
> return -EFAULT;
> unsafe_get_user(val, from, Efault);
> - user_access_end();
> + user_read_access_end();
> *dest = val;
> return 0;
> Efault:
Thanks, I can confirm that this fixed the crash (changing both arms as
pointed out by Christophe).
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
prev parent reply other threads:[~2024-12-09 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241122193305.7316-1-torvalds@linux-foundation.org>
2024-12-08 22:54 ` [PATCH] futex: improve user space accesses Andreas Schwab
2024-12-09 0:32 ` Linus Torvalds
2024-12-09 8:00 ` Christophe Leroy
2024-12-09 18:32 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjxkzoz0.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).