From: Michael Ellerman <mpe@ellerman.id.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Sean Christopherson <seanjc@google.com>
Cc: linux-arch@vger.kernel.org, x86@kernel.org,
Will Deacon <will@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Daniel Sneddon <daniel.sneddon@linux.intel.com>
Subject: Re: [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n
Date: Sat, 13 Apr 2024 19:38:47 +1000 [thread overview]
Message-ID: <87bk6dd2l4.fsf@mail.lhotse> (raw)
In-Reply-To: <87edb9d33r.fsf@mail.lhotse>
Michael Ellerman <mpe@ellerman.id.au> writes:
> Stephen Rothwell <sfr@canb.auug.org.au> writes:
...
>> On Tue, 9 Apr 2024 10:51:05 -0700 Sean Christopherson <seanjc@google.com> wrote:
...
>>> diff --git a/kernel/cpu.c b/kernel/cpu.c
>>> index 8f6affd051f7..07ad53b7f119 100644
>>> --- a/kernel/cpu.c
>>> +++ b/kernel/cpu.c
>>> @@ -3207,7 +3207,8 @@ enum cpu_mitigations {
>>> };
>>>
>>> static enum cpu_mitigations cpu_mitigations __ro_after_init =
>>> - CPU_MITIGATIONS_AUTO;
>>> + IS_ENABLED(CONFIG_SPECULATION_MITIGATIONS) ? CPU_MITIGATIONS_AUTO :
>>> + CPU_MITIGATIONS_OFF;
>>>
>>> static int __init mitigations_parse_cmdline(char *arg)
>>> {
I think a minimal workaround/fix would be:
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 2b8fd6bb7da0..290be2f9e909 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -191,6 +191,10 @@ config GENERIC_CPU_AUTOPROBE
config GENERIC_CPU_VULNERABILITIES
bool
+config SPECULATION_MITIGATIONS
+ def_bool y
+ depends on !X86
+
config SOC_BUS
bool
select GLOB
cheers
next prev parent reply other threads:[~2024-04-13 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240409175108.1512861-1-seanjc@google.com>
[not found] ` <20240409175108.1512861-2-seanjc@google.com>
2024-04-13 1:53 ` [PATCH 1/3] x86/cpu: Actually turn off mitigations by default for SPECULATION_MITIGATIONS=n Stephen Rothwell
2024-04-13 9:27 ` Michael Ellerman
2024-04-13 9:38 ` Michael Ellerman [this message]
2024-04-14 22:42 ` Stephen Rothwell
2024-04-15 11:16 ` Geert Uytterhoeven
2024-04-15 14:31 ` Sean Christopherson
2024-04-16 11:06 ` Michael Ellerman
2024-04-19 14:03 ` Will Deacon
2024-04-19 14:06 ` Sean Christopherson
2024-04-19 14:38 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk6dd2l4.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hca@linux.ibm.com \
--cc=jpoimboe@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).