From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 324FCC05027 for ; Mon, 20 Feb 2023 00:43:38 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PKkDm05D6z3bXQ for ; Mon, 20 Feb 2023 11:43:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=IQA2gF1P; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PKkCl1XXgz3bXP for ; Mon, 20 Feb 2023 11:42:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=IQA2gF1P; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4PKkCk2nhqz4x7y; Mon, 20 Feb 2023 11:42:42 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1676853762; bh=awL0LswKWKQU0tm7U0FyvskVuBx2M8+vxaPhhqV23ug=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IQA2gF1Pd/CGSf8+a0zgq6k2DXLp9teYLySBIzInVqukEPLw2XlVJCwiUoHAFcSdp Y9/ZYFyBIWRLUgjCQcCHeOfRyDtu0gUMIr652VyGS/vsb1TU2Yn0PP0ltuDaIchuqN X7+2nkjkncI9glOdsgedKyNgVon5wzY1ZxbnnW4gItc13eztnhiQUR2jpzLh809lJ1 efDm1+lYxxspKEXmaGOaPhpjnm3Owec++PvViQOk1DgTkcqPV2mAFE0/KidDEWfArR iGt+bJyde/12EvJWTkvXYiDZncHIHmG7e9qY+NkENi9Or4ci3ziqvwKVxKNoZV2Ahx zV9gprLHcg5cA== From: Michael Ellerman To: Joe Perches , Christophe Leroy , Pali =?utf-8?Q?Roh=C3=A1r?= , Nicholas Piggin Subject: Re: [PATCH v2 09/10] powerpc: Use ppc_md_progress() In-Reply-To: <45807c0e9fc818dd433746fbb55988c73b016477.camel@perches.com> References: <6cb9865d916231c38401ba34ad1a98c249fae135.1676711562.git.christophe.leroy@csgroup.eu> <45807c0e9fc818dd433746fbb55988c73b016477.camel@perches.com> Date: Mon, 20 Feb 2023 11:42:36 +1100 Message-ID: <87bklpyxoj.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Joe Perches writes: > On Sat, 2023-02-18 at 10:15 +0100, Christophe Leroy wrote: >> Many places have: >> >> if (ppc.md_progress) >> ppc.md_progress(); >> >> Use ppc_md_progress() instead. >> >> Note that checkpatch complains about using function names, >> but this is not a function taking format strings, so we >> leave the function names for now. > > If you are changing almost all of these uses, why not > drop the unused 2nd argument 'hex' at the same time? The hex argument is printed by some "progress" implementations. rtas_progress() will print it to the machine's 7-segment display on some very old machines. Grepping around I think it might be only old CHRP machines that use the hex code. And we only have a handful of sites that actually pass a non-zero hex code anyway. So I think we could drop the hex argument. But the vast bulk of the uses are just printing "foo_setup_arch()" which is of dubious utility and could probably just be dropped. If the machine has a working udbg backend then before we get to setup arch we will have initialised the udbg console, and so all printk messages should be going to udbg anyway. cheers