From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93E75C47DD9 for ; Wed, 28 Feb 2024 05:38:10 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=JwSMTu/c; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Tl36T0TVvz3dSp for ; Wed, 28 Feb 2024 16:38:09 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=JwSMTu/c; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Tl35c14w3z3byT for ; Wed, 28 Feb 2024 16:37:24 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1709098644; bh=WrzBRPEbMC6sMsS/NGeRTcI4E0TvRn8j9WzB+h+U+0s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JwSMTu/c4WXVmSxe+KfxYctgyIYeFkLJJpIjLQ6SkHSqX20oZRSdbxZDFKV6K/1KQ 6C3rUOI7G73yyvXygdHNiXAikpA4tLd7kosG3yXCldb3iTl1NT4C6IYHLATqgi0NVh kAr6Z+VEKKbMV6IuyY9CPD01RX5J0d3g5oCWLKumDL4dO0oOi9+SlufVquN+SKFuGH 94e3wPuva+BzHfNUmLHBk9iV/f9LFu6N9NhNp3FjqFJSV+8HK9TSwQf7mkUPcQ/SqI wS+CAkb7AHHnImKmBI5rUKRorCEL/+0QK9IZ167FKlgqVlaHXYC19ieT09pRti+WlY j+4OW7j3/UihA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Tl35Z2kBSz4wc6; Wed, 28 Feb 2024 16:37:22 +1100 (AEDT) From: Michael Ellerman To: Christophe Leroy , Uwe =?utf-8?Q?Kleine-K?= =?utf-8?Q?=C3=B6nig?= Subject: Re: Increasing build coverage for drivers/spi/spi-ppc4xx.c In-Reply-To: References: <6fab09e0-1f21-4ada-b5ae-472bf71a1225@csgroup.eu> <7ah7rzijbwkvr3hmtqfjh7syxave756usevumrypqspn27wgyv@ln42tyqxo5ai> <2fe58bc5-2f1b-4f51-8f01-fa397a1c9291@csgroup.eu> <645ngchmigftlvbvquprqqjcn2frogkihdplbmngnz6hvywefo@rvthwy2epwg3> Date: Wed, 28 Feb 2024 16:37:22 +1100 Message-ID: <87cysh1759.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicholas Piggin , "linux-spi@vger.kernel.org" , "Aneesh Kumar K.V" , Mark Brown , "Naveen N. Rao" , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Christophe Leroy writes: > Le 27/02/2024 =C3=A0 15:00, Uwe Kleine-K=C3=B6nig a =C3=A9crit=C2=A0: >> On Tue, Feb 27, 2024 at 01:52:07PM +0000, Christophe Leroy wrote: >>> Le 27/02/2024 =C3=A0 11:58, Uwe Kleine-K=C3=B6nig a =C3=A9crit=C2=A0: >>>> On Tue, Feb 27, 2024 at 10:25:15AM +0000, Christophe Leroy wrote: >>>>> Le 27/02/2024 =C3=A0 09:46, Uwe Kleine-K=C3=B6nig a =C3=A9crit=C2=A0: >>>>>> recently the spi-ppc4xx.c driver suffered from build errors and warn= ings >>>>>> that were undetected for longer than I expected. I think it would be >>>>>> very beneficial if this driver was enabled in (at least) a powerpc >>>>>> allmodconfig build. >>>>>> >>>>>> The challenge to do so is that spi-ppc4xx.c uses dcri_clrset() which= is >>>>>> only defined for 4xx (as these select PPC_DCR_NATIVE). ... >>=20 >> The reason I'd like to see it in allmodconfig is that testing >> allmodconfig on several archs is the check I do for my patch series. > > I think for powerpc you should really check ppc32_allmodconfig in=20 > addition to allmodconfig Yeah. arch/powerpc is really ~7 separate sub architectures. Building allmodconfig and ppc32_allmodconfig at least covers the bulk of the code. But it doesn't include 4xx, or several other platforms. I think the best/easiest option is just to enable this driver in the 44x defconfig. At least that way the auto builders should catch any problems. eg. diff --git a/arch/powerpc/configs/ppc44x_defconfig b/arch/powerpc/configs/p= pc44x_defconfig index 8b595f67068c..95a1e7efb79f 100644 --- a/arch/powerpc/configs/ppc44x_defconfig +++ b/arch/powerpc/configs/ppc44x_defconfig @@ -67,6 +67,8 @@ CONFIG_I2C=3Dm CONFIG_I2C_CHARDEV=3Dm CONFIG_I2C_GPIO=3Dm CONFIG_I2C_IBM_IIC=3Dm +CONFIG_SPI=3Dy +CONFIG_SPI_PPC4xx=3Dy # CONFIG_HWMON is not set CONFIG_FB=3Dm CONFIG_USB=3Dm cheers