From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD4FBC433E0 for ; Thu, 28 May 2020 12:26:46 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C84420888 for ; Thu, 28 May 2020 12:26:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="QVgS1zFf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C84420888 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49Xn4h3RZ2zDqZ1 for ; Thu, 28 May 2020 22:26:44 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49Xn154cG6zDqQr for ; Thu, 28 May 2020 22:23:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=QVgS1zFf; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49Xn1363Fzz9sSF; Thu, 28 May 2020 22:23:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1590668617; bh=hIKUVBa7d1wuMGALSM0shNFll3TSEEkKGOhFvLGz82Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QVgS1zFfMMqL1C0G1D9y0F8uEplEaqsZuG6w6vpbUDMY7yuD7IrhWYi5xmwJX831P U9xV7nTUP4uf6TqM8IrShFCPwUCUH0HlF5Cwan4ANsBrHF4Jdf6bCYvNzCFU3eHsL2 xb2rEQhJzoACq34EZhmwPQcUwPZk5DlNJeXxWdk6ZPF10P/ucxOkda++nnMde1FhC4 yP+E/UZsizfT/DXyA0Y1s+UTPjjRpQPNboTtorlYWOKyoL3goRsylVVdZqyRBe6/7V 9kuzfkjLWza0P8eUO8Fae1QlcsAcKzpH6DAYA0AlXcw5yyN0BvCQDNDT1iVnXLl6lo +Y+3U/6Pms/oA== From: Michael Ellerman To: Petr Mladek Subject: Re: [PATCH] powerpc/bpf: Enable bpf_probe_read{, str}() on powerpc again In-Reply-To: <20200528091351.GE3529@linux-b0ei> References: <20200527122844.19524-1-pmladek@suse.com> <87ftbkkh00.fsf@mpe.ellerman.id.au> <20200528091351.GE3529@linux-b0ei> Date: Thu, 28 May 2020 22:23:56 +1000 Message-ID: <87d06ojlib.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Borkmann , linux-kernel@vger.kernel.org, Alexei Starovoitov , Paul Mackerras , Masami Hiramatsu , Brendan Gregg , Miroslav Benes , linuxppc-dev@lists.ozlabs.org, Christoph Hellwig Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Petr Mladek writes: > On Thu 2020-05-28 11:03:43, Michael Ellerman wrote: >> Petr Mladek writes: >> > The commit 0ebeea8ca8a4d1d453a ("bpf: Restrict bpf_probe_read{, str}() only >> > to archs where they work") caused that bpf_probe_read{, str}() functions >> > were not longer available on architectures where the same logical address >> > might have different content in kernel and user memory mapping. These >> > architectures should use probe_read_{user,kernel}_str helpers. >> > >> > For backward compatibility, the problematic functions are still available >> > on architectures where the user and kernel address spaces are not >> > overlapping. This is defined CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE. >> > >> > At the moment, these backward compatible functions are enabled only >> > on x86_64, arm, and arm64. Let's do it also on powerpc that has >> > the non overlapping address space as well. >> > >> > Signed-off-by: Petr Mladek >> >> This seems like it should have a Fixes: tag and go into v5.7? > > Good point: > > Fixes: commit 0ebeea8ca8a4d1d4 ("bpf: Restrict bpf_probe_read{, str}() only to archs where they work") > > And yes, it should ideally go into v5.7 either directly or via stable. > > Should I resend the patch with Fixes and > Cc: stable@vger.kernel.org #v45.7 lines, please? If it goes into v5.7 then it doesn't need a Cc: stable, and I guess a Fixes: tag is nice to have but not so important as it already mentions the commit that caused the problem. So a resend probably isn't necessary. Acked-by: Michael Ellerman Daniel can you pick this up, or should I? cheers