From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E3C5C43387 for ; Wed, 19 Dec 2018 00:25:33 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7AAD2184C for ; Wed, 19 Dec 2018 00:25:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7AAD2184C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 43KFzG6sPVzDqgd for ; Wed, 19 Dec 2018 11:25:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 43KFvb2qp5zDql9 for ; Wed, 19 Dec 2018 11:22:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 43KFvb15Qkz9s1c; Wed, 19 Dec 2018 11:22:19 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au From: Michael Ellerman To: Mathieu Malaterre Subject: Re: [PATCH] powerpc/ptrace: fix empty-body warning In-Reply-To: <20181218205305.26647-1-malat@debian.org> References: <20181218205305.26647-1-malat@debian.org> Date: Wed, 19 Dec 2018 11:22:19 +1100 Message-ID: <87d0pys6v8.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Malaterre , Oleg Nesterov , linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Mathieu, Mathieu Malaterre writes: > In commit a225f1567405 ("powerpc/ptrace: replace ptrace_report_syscall() > with a tracehook call") an empty body if(); was added. > > Replace ; with {} to remove a warning (treated as error) reported by gcc > using W=3D1: > > arch/powerpc/kernel/ptrace.c: In function =E2=80=98do_syscall_trace_ent= er=E2=80=99: > arch/powerpc/kernel/ptrace.c:3281:4: error: suggest braces around empty= body in an =E2=80=98if=E2=80=99 statement [-Werror=3Dempty-body] > > Fixes: a225f1567405 ("powerpc/ptrace: replace ptrace_report_syscall() wit= h a tracehook call") > Signed-off-by: Mathieu Malaterre Thanks for the fix, but this code is being refactored already in next, see: https://patchwork.ozlabs.org/patch/1014179/ cheers