From: Thomas Gleixner <tglx@linutronix.de>
To: "Farber, Eliav" <farbere@amazon.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
"naveen@kernel.org" <naveen@kernel.org>,
"maddy@linux.ibm.com" <maddy@linux.ibm.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"bhe@redhat.com" <bhe@redhat.com>,
"hbathini@linux.ibm.com" <hbathini@linux.ibm.com>,
"sourabhjain@linux.ibm.com" <sourabhjain@linux.ibm.com>,
"adityag@linux.ibm.com" <adityag@linux.ibm.com>,
"songshuaishuai@tinylab.org" <songshuaishuai@tinylab.org>,
"takakura@valinux.co.jp" <takakura@valinux.co.jp>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Cc: "Chocron, Jonathan" <jonnyc@amazon.com>
Subject: RE: [PATCH v5 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation
Date: Tue, 03 Dec 2024 17:36:59 +0100 [thread overview]
Message-ID: <87ed2ou3is.ffs@tglx> (raw)
In-Reply-To: <077908c5f02545f0a9e02ae77cbd771c@amazon.com>
On Tue, Dec 03 2024 at 12:55, Eliav Farber wrote:
> On 12/3/2024 1:04 PM, Thomas Gleixner wrote:
>>> +
>>> +config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD
>>> + bool "Clear forwarded VM interrupts during kexec"
>>
>> This should not be user selectable. Just keep it as:
>>
>> config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD
>> bool
>>
>> which defaults to 'n'. Just add a comment what this is about like it's
>> done with the other options in that file which are only selectable.
> Question: Should this new configuration option be placed inside or
> outside the following section:
> ```
> menu "IRQ subsystem"
>
>
> endmenu
> ```
> In my patch, I have added the new configuration option at the end of
> the file, outside the "IRQ subsystem" section.
It does not really matter when the option is silent, but keeping it in
the menu section as the others is the most intuitive IMO.
Thanks,
tglx
next prev parent reply other threads:[~2024-12-03 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 12:55 [PATCH v5 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation Farber, Eliav
2024-12-03 16:36 ` Thomas Gleixner [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-04 11:40 Farber, Eliav
2024-12-04 14:07 ` Thomas Gleixner
2024-11-30 20:11 [PATCH v5 0/2] Improve interrupt handling during machine kexec Eliav Farber
2024-11-30 20:11 ` [PATCH v5 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation Eliav Farber
2024-12-03 11:04 ` Thomas Gleixner
2024-12-04 11:02 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed2ou3is.ffs@tglx \
--to=tglx@linutronix.de \
--cc=adityag@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=farbere@amazon.com \
--cc=hbathini@linux.ibm.com \
--cc=jonnyc@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=songshuaishuai@tinylab.org \
--cc=sourabhjain@linux.ibm.com \
--cc=takakura@valinux.co.jp \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).