From: Michael Ellerman <mpe@ellerman.id.au>
To: "Li Yang" <leoyang.li@nxp.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Stuart Yoder <stuyoder@gmail.com>,
Gaurav Jain <gaurav.jain@nxp.com>,
Roy Pledge <roy.pledge@nxp.com>,
"Diana Madalina Craciun \(OSS\)" <diana.craciun@oss.nxp.com>,
Eric Dumazet <edumazet@google.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Horia Geanta <horia.geanta@nxp.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Richard Cochran <richardcochran@gmail.com>,
Pankaj Gupta <pankaj.gupta@nxp.com>,
Alex Williamson <alex.williamson@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vinod Koul <vkoul@kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"Y.B. Lu" <yangbo.lu@nxp.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void
Date: Tue, 09 May 2023 17:20:48 +1000 [thread overview]
Message-ID: <87ednqx967.fsf@mail.lhotse> (raw)
In-Reply-To: <CADRPPNQ0QiLzzKhHon62haPJCanDoN=B4QsWCxunJTc4wXwMaA@mail.gmail.com>
Li Yang <leoyang.li@nxp.com> writes:
> On Mon, May 8, 2023 at 8:44 AM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
>>
>> Hello Leo,
>>
>> On Thu, Apr 13, 2023 at 08:00:04AM +0200, Uwe Kleine-König wrote:
>> > On Wed, Apr 12, 2023 at 09:30:05PM +0000, Leo Li wrote:
>> > > > On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
>> > > > > Hello,
>> > > > >
>> > > > > many bus remove functions return an integer which is a historic
>> > > > > misdesign that makes driver authors assume that there is some kind of
>> > > > > error handling in the upper layers. This is wrong however and
>> > > > > returning and error code only yields an error message.
>> > > > >
>> > > > > This series improves the fsl-mc bus by changing the remove callback to
>> > > > > return no value instead. As a preparation all drivers are changed to
>> > > > > return zero before so that they don't trigger the error message.
>> > > >
>> > > > Who is supposed to pick up this patch series (or point out a good reason for
>> > > > not taking it)?
>> > >
>> > > Previously Greg KH picked up MC bus patches.
>> > >
>> > > If no one is picking up them this time, I probably can take it through
>> > > the fsl soc tree.
>> >
>> > I guess Greg won't pick up this series as he didn't get a copy of it :-)
>> >
>> > Browsing through the history of drivers/bus/fsl-mc there is no
>> > consistent maintainer to see. So if you can take it, that's very
>> > appreciated.
>>
>> My mail was meant encouraging, maybe it was too subtile? I'll try again:
>>
>> Yes, please apply, that would be wonderful!
>
> Sorry for missing your previous email. I will do that. Thanks.
Does MAINTAINERS need updating?
It says:
QORIQ DPAA2 FSL-MC BUS DRIVER
M: Stuart Yoder <stuyoder@gmail.com>
M: Laurentiu Tudor <laurentiu.tudor@nxp.com>
L: linux-kernel@vger.kernel.org
S: Maintained
...
F: drivers/bus/fsl-mc/
cheers
next prev parent reply other threads:[~2023-05-09 7:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 22:41 [PATCH 0/6] bus: fsl-mc: Make remove function return void Uwe Kleine-König
2023-03-10 22:41 ` [PATCH 5/6] soc: fsl: dpio: Suppress duplicated error reporting on device remove Uwe Kleine-König
2023-03-10 22:41 ` [PATCH 6/6] bus: fsl-mc: Make remove function return void Uwe Kleine-König
2023-03-13 13:46 ` [PATCH 0/6] " Ioana Ciornei
2023-03-13 15:47 ` Laurentiu Tudor
2023-04-12 17:10 ` Uwe Kleine-König
2023-04-12 21:30 ` Leo Li
2023-04-13 6:00 ` Uwe Kleine-König
2023-05-08 13:43 ` Uwe Kleine-König
2023-05-08 21:57 ` Li Yang
2023-05-09 7:20 ` Michael Ellerman [this message]
2023-05-30 13:50 ` Uwe Kleine-König
2023-05-31 0:01 ` Leo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ednqx967.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=alex.williamson@redhat.com \
--cc=davem@davemloft.net \
--cc=diana.craciun@oss.nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gaurav.jain@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=ioana.ciornei@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.gupta@nxp.com \
--cc=richardcochran@gmail.com \
--cc=roy.pledge@nxp.com \
--cc=stuyoder@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).