From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (unknown [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE41FC77B75 for ; Tue, 9 May 2023 07:21:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QFqN43nHgz3fKy for ; Tue, 9 May 2023 17:21:40 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=gywRbWdS; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QFqM76N5cz3ccn for ; Tue, 9 May 2023 17:20:51 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=gywRbWdS; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QFqM52DdNz4x3g; Tue, 9 May 2023 17:20:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1683616851; bh=2wjmKTbt/z5/1Lgzb67uZ1KsoxbcTNd7BEGnUaPkJ+A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gywRbWdSmUgbLXjnspObVrUv7pOsxsVhSbXU+zEQv1KxI3iQgbMLGV1sgY9TK3HlP mxau4GAW14GS7xLkEVVGt6TSUjDdnI5gQ/yqzOjt4UCnnZWSLHcIgVNj68ChxG08lD vRtFnnM842n16stuYmzmQHCXsKAqPyWp2WWJvsx+jRTLU9LsG8XgXgmPcL/RXmpXPi oQLUh6oCZ+H+Syx+bRcmjd7Wh6fDNKVW4OIOcI6c8JL50e0arVtLxUfpndCjg58KQP Nb4QsloFLe6SCwbo8J9T15yZrdQuazh7lwYNglnE2FlJrSPA1dTdzlh4JYwTc8ZYnb FZOpgLXwBHWlg== From: Michael Ellerman To: Li Yang , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void In-Reply-To: References: <20230310224128.2638078-1-u.kleine-koenig@pengutronix.de> <20230412171056.xcluewbuyytm77yp@pengutronix.de> <20230413060004.t55sqmfxqtnejvkc@pengutronix.de> <20230508134300.s36d6k4e25f6ubg4@pengutronix.de> Date: Tue, 09 May 2023 17:20:48 +1000 Message-ID: <87ednqx967.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stuart Yoder , Gaurav Jain , Roy Pledge , "Diana Madalina Craciun \(OSS\)" , Eric Dumazet , Ioana Ciornei , "kvm@vger.kernel.org" , Horia Geanta , Jakub Kicinski , Paolo Abeni , Laurentiu Tudor , Richard Cochran , Pankaj Gupta , Alex Williamson , "linux-arm-kernel@lists.infradead.org" , Herbert Xu , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Vinod Koul , "linux-crypto@vger.kernel.org" , "kernel@pengutronix.de" , "Y.B. Lu" , "dmaengine@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Li Yang writes: > On Mon, May 8, 2023 at 8:44=E2=80=AFAM Uwe Kleine-K=C3=B6nig > wrote: >> >> Hello Leo, >> >> On Thu, Apr 13, 2023 at 08:00:04AM +0200, Uwe Kleine-K=C3=B6nig wrote: >> > On Wed, Apr 12, 2023 at 09:30:05PM +0000, Leo Li wrote: >> > > > On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-K=C3=B6nig wr= ote: >> > > > > Hello, >> > > > > >> > > > > many bus remove functions return an integer which is a historic >> > > > > misdesign that makes driver authors assume that there is some ki= nd of >> > > > > error handling in the upper layers. This is wrong however and >> > > > > returning and error code only yields an error message. >> > > > > >> > > > > This series improves the fsl-mc bus by changing the remove callb= ack to >> > > > > return no value instead. As a preparation all drivers are change= d to >> > > > > return zero before so that they don't trigger the error message. >> > > > >> > > > Who is supposed to pick up this patch series (or point out a good = reason for >> > > > not taking it)? >> > > >> > > Previously Greg KH picked up MC bus patches. >> > > >> > > If no one is picking up them this time, I probably can take it throu= gh >> > > the fsl soc tree. >> > >> > I guess Greg won't pick up this series as he didn't get a copy of it := -) >> > >> > Browsing through the history of drivers/bus/fsl-mc there is no >> > consistent maintainer to see. So if you can take it, that's very >> > appreciated. >> >> My mail was meant encouraging, maybe it was too subtile? I'll try again: >> >> Yes, please apply, that would be wonderful! > > Sorry for missing your previous email. I will do that. Thanks. Does MAINTAINERS need updating? It says: QORIQ DPAA2 FSL-MC BUS DRIVER M: Stuart Yoder M: Laurentiu Tudor L: linux-kernel@vger.kernel.org S: Maintained ... F: drivers/bus/fsl-mc/ cheers