From: Thomas Gleixner <tglx@linutronix.de>
To: Laurent Vivier <lvivier@redhat.com>, linux-kernel@vger.kernel.org
Cc: Laurent Vivier <lvivier@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
linux-pci@vger.kernel.org, linux-block@vger.kernel.org,
Paul Mackerras <paulus@samba.org>, Marc Zyngier <maz@kernel.org>,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/2] powerpc/pseries: pass MSI affinity to irq_create_mapping()
Date: Tue, 24 Nov 2020 23:35:34 +0100 [thread overview]
Message-ID: <87eekil6x5.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20201124200308.1110744-3-lvivier@redhat.com>
On Tue, Nov 24 2020 at 21:03, Laurent Vivier wrote:
> With virtio multiqueue, normally each queue IRQ is mapped to a CPU.
>
> This problem cannot be shown on x86_64 for two reasons:
There is only _ONE_ reason why this is not a problem on x86. x86 uses
the generic PCI/MSI domain which supports this out of the box.
> - the call path traverses arch_setup_msi_irqs() that is arch specific:
>
> virtscsi_probe()
> virtscsi_init()
> vp_modern_find_vqs()
> vp_find_vqs()
> vp_find_vqs_msix()
> pci_alloc_irq_vectors_affinity()
> __pci_enable_msix_range()
> pci_msi_setup_msi_irqs()
> arch_setup_msi_irqs()
> rtas_setup_msi_irqs()
This is a problem on _all_ variants of PPC MSI providers, not only for
pseries. It's not restricted to virtscsi devices either, that's just the
device which made you discover this.
Thanks,
tglx
next prev parent reply other threads:[~2020-11-24 22:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 20:03 [PATCH 0/2] powerpc/pseries: fix MSI/X IRQ affinity on pseries Laurent Vivier
2020-11-24 20:03 ` [PATCH 1/2] genirq: add an affinity parameter to irq_create_mapping() Laurent Vivier
2020-11-24 22:19 ` Thomas Gleixner
2020-11-25 7:30 ` Laurent Vivier
2020-11-24 22:50 ` kernel test robot
2020-11-25 1:03 ` kernel test robot
2020-11-24 20:03 ` [PATCH 2/2] powerpc/pseries: pass MSI affinity " Laurent Vivier
2020-11-24 22:35 ` Thomas Gleixner [this message]
2020-11-24 21:08 ` [PATCH 0/2] powerpc/pseries: fix MSI/X IRQ affinity on pseries Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eekil6x5.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
--cc=maz@kernel.org \
--cc=mst@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).