From: Michael Ellerman <mpe@ellerman.id.au>
To: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/2] of: Add of_machine_compatible_match()
Date: Fri, 03 Aug 2018 20:31:03 +1000 [thread overview]
Message-ID: <87efffhhco.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <CAL_JsqKYFk6-ofDFvaiy3a+r8Zyzw2UuMQUHb-RrgeWfpjom5w@mail.gmail.com>
Rob Herring <robh+dt@kernel.org> writes:
> On Mon, Jul 30, 2018 at 7:15 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
...
>> diff --git a/include/linux/of.h b/include/linux/of.h
>> index 4d25e4f952d9..05e3e23a3a57 100644
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -389,6 +389,7 @@ extern int of_alias_get_id(struct device_node *np, const char *stem);
>> extern int of_alias_get_highest_id(const char *stem);
>>
>> extern int of_machine_is_compatible(const char *compat);
>> +extern bool of_machine_compatible_match(const char *const *compats);
>
> Would be nice if of_machine_is_compatible could be implemented in
> terms of of_machine_compatible_match like this:
>
> int of_machine_is_compatible(const char *compat)
> {
> const char *compats[] = { compat, NULL };
> return of_machine_is_compatible(compats);
> }
>
> Probably can be inline too.
Yeah good idea, I'll do a v2 next week.
cheers
prev parent reply other threads:[~2018-08-03 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 13:15 [PATCH 1/2] of: Add of_machine_compatible_match() Michael Ellerman
2018-07-30 13:15 ` [PATCH 2/2] powerpc: Use of_machine_compatible_match() Michael Ellerman
2018-07-30 14:14 ` Rob Herring
2018-07-30 14:06 ` [PATCH 1/2] of: Add of_machine_compatible_match() Rob Herring
2018-08-03 10:31 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efffhhco.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox