From: Michael Ellerman <mpe@ellerman.id.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
PowerPC <linuxppc-dev@lists.ozlabs.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: build warning in drivers/macintosh/rack-meter.c
Date: Fri, 16 Mar 2018 21:22:33 +1100 [thread overview]
Message-ID: <87efkkfhg6.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180316164614.07f2f573@canb.auug.org.au>
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi all,
>
> These warnings have beeen around for a while now;
>
> drivers/macintosh/rack-meter.c:157:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
> memset(rdma->buf1, 0, ARRAY_SIZE(rdma->buf1));
> ^~~~~~
> drivers/macintosh/rack-meter.c:158:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
> memset(rdma->buf2, 0, ARRAY_SIZE(rdma->buf2));
> ^~~~~~
>
> Introduced by commit
>
> 4f7bef7a9f69 ("drivers: macintosh: rack-meter: fix bogus memsets")
Yep looks like a bug.
Aaro, can you send a patch?
cheers
prev parent reply other threads:[~2018-03-16 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 5:46 build warning in drivers/macintosh/rack-meter.c Stephen Rothwell
2018-03-16 9:37 ` Aaro Koskinen
2018-03-16 9:50 ` Stephen Rothwell
2018-03-16 10:22 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efkkfhg6.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aaro.koskinen@iki.fi \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox