From: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
"Alastair D'Silva" <alastair@linux.ibm.com>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Christophe Lombard <christophe_lombard@fr.ibm.com>
Subject: Re: [PATCH v3] powerpc: Avoid signed to unsigned conversion in set_thread_tidr()
Date: Tue, 28 Nov 2017 08:27:32 +0530 [thread overview]
Message-ID: <87efojm7oj.fsf@vajain21.in.ibm.com> (raw)
In-Reply-To: <20171127234158.GA8067@us.ibm.com>
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> writes:
> We can eliminate the 'else' and be consistent with existing code, if
> we check for error (i.e rc < 0) and return rc. assign_thread_tidr() will
> not return 0, but even if it did, setting the register and thread.tidr
> to 0 should not be a problem.
Thanks for the suggestion Sukadev. I have sent out a v4 at
http://patchwork.ozlabs.org/patch/841937/ with the update.
--
Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.
prev parent reply other threads:[~2017-11-28 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 17:19 [PATCH v3] powerpc: Avoid signed to unsigned conversion in set_thread_tidr() Vaibhav Jain
2017-11-27 23:41 ` Sukadev Bhattiprolu
2017-11-28 2:57 ` Vaibhav Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efojm7oj.fsf@vajain21.in.ibm.com \
--to=vaibhav@linux.vnet.ibm.com \
--cc=alastair@linux.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=christophe_lombard@fr.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=philippe.bergheaud@fr.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).