From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yMyPN41cSzDqfh for ; Thu, 26 Oct 2017 17:52:39 +1100 (AEDT) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9Q6mdwQ141774 for ; Thu, 26 Oct 2017 02:52:36 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 2du8b9xn2j-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 26 Oct 2017 02:52:36 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Oct 2017 07:52:34 +0100 From: "Aneesh Kumar K.V" To: Nicholas Piggin , linuxppc-dev@lists.ozlabs.org Cc: Nicholas Piggin , Benjamin Herrenschmidt Subject: Re: [PATCH v2 1/3] powerpc/64s/radix: fix preempt imbalance in TLB flush In-Reply-To: <20171024130654.1223-2-npiggin@gmail.com> References: <20171024130654.1223-1-npiggin@gmail.com> <20171024130654.1223-2-npiggin@gmail.com> Date: Thu, 26 Oct 2017 12:22:29 +0530 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87efpq2yfm.fsf@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Nicholas Piggin writes: Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/mm/tlb-radix.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c > index 3a07d7a5e2fe..892544ebc2d2 100644 > --- a/arch/powerpc/mm/tlb-radix.c > +++ b/arch/powerpc/mm/tlb-radix.c > @@ -358,7 +358,7 @@ void radix__flush_tlb_collapsed_pmd(struct mm_struct *mm, unsigned long addr) > unsigned long ap = mmu_get_ap(mmu_virtual_psize); > unsigned long pid, end; > > - > + preempt_disable(); > pid = mm->context.id; > if (unlikely(pid == MMU_NO_CONTEXT)) > goto no_context; > @@ -366,6 +366,7 @@ void radix__flush_tlb_collapsed_pmd(struct mm_struct *mm, unsigned long addr) > /* 4k page size, just blow the world */ > if (PAGE_SIZE == 0x1000) { > radix__flush_all_mm(mm); > + preempt_enable(); > return; > } > > -- > 2.13.3