From: Andreas Schwab <schwab@linux-m68k.org>
To: Timur Tabi <timur@tabi.org>
Cc: "Harisangam\, Sharvari \(S.\)" <sharvari.harisangam@visteon.com>,
"alsa-devel\@alsa-project.org" <alsa-devel@alsa-project.org>,
Xiubo Li <Xiubo.Lee@gmail.com>, Takashi Iwai <tiwai@suse.de>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
"linuxppc-dev\@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode
Date: Wed, 28 Dec 2016 17:52:43 +0100 [thread overview]
Message-ID: <87eg0sf12c.fsf@linux-m68k.org> (raw)
In-Reply-To: <9ebb798c-6040-9262-9625-ddcebd05a188__32955.7460187518$1482940206$gmane$org@tabi.org> (Timur Tabi's message of "Wed, 28 Dec 2016 09:48:42 -0600")
On Dez 28 2016, Timur Tabi <timur@tabi.org> wrote:
> Andreas Schwab wrote:
>>> > + return !!(ssi_private->dai_fmt & SND_SOC_DAIFMT_AC97) ==
>>> > + SND_SOC_DAIFMT_AC97;
>> This is never true.
>
> I think the right parenthesis should be at the end of the expression.
That would still test the wrong bitfield.
And all that is obsolete anyway since commit 5b64c173cd (of Sep 2015).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2016-12-28 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 11:06 [PATCH] ASoC : fsl_ssi : Correct the condition to check AC97 mode Harisangam, Sharvari (S.)
2016-12-28 14:50 ` Andreas Schwab
2016-12-28 15:48 ` Timur Tabi
2016-12-28 15:53 ` Harisangam, Sharvari (S.)
[not found] ` <9ebb798c-6040-9262-9625-ddcebd05a188__32955.7460187518$1482940206$gmane$org@tabi.org>
2016-12-28 16:52 ` Andreas Schwab [this message]
2016-12-28 17:53 ` [alsa-devel] " Fabio Estevam
2017-01-04 12:22 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg0sf12c.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=sharvari.harisangam@visteon.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).