From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>, linuxppc-dev@ozlabs.org
Cc: mpe@ellerman.id.au, mikey@neuling.org
Subject: Re: [RFC] powerpc/hugetlb: Add warning message when gpage allocation request fails
Date: Mon, 14 Sep 2015 18:59:25 +0530 [thread overview]
Message-ID: <87egi1f7t6.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1442212051-15235-1-git-send-email-khandual@linux.vnet.ibm.com>
Anshuman Khandual <khandual@linux.vnet.ibm.com> writes:
> When a 16GB huge page is requested on POWER platform through kernel command
> line interface, it silently fails because of the lack of any gigantic pages
> on the system which the platform should have communicated through 16GB memory
> blocks in the device tree during boot time. For example
>
> [ 0.480940] HugeTLB registered 16 GB page size, pre-allocated 0 pages
> [ 0.480945] HugeTLB registered 16 MB page size, pre-allocated 16 pages
>
> This adds a warning message during alloc_bootmem_huge_page request both on
> book3e and book3s powerpc platforms. After this change
>
> [ 0.000000] Gigantic HugeTLB page not available
> [ 0.473417] HugeTLB registered 16 GB page size, pre-allocated 0 pages
> [ 0.473423] HugeTLB registered 16 MB page size, pre-allocated 16 pages
That info is already part of the second line isn't it ? ie
[ 0.473417] HugeTLB registered 16 GB page size, pre-allocated 0 pages
pre-allocated 0 pages indicate we didn't allocate anything. So why do we
need to add more details fo kernel output ?
-aneesh
next prev parent reply other threads:[~2015-09-14 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 6:27 [RFC] powerpc/hugetlb: Add warning message when gpage allocation request fails Anshuman Khandual
2015-09-14 13:29 ` Aneesh Kumar K.V [this message]
2015-09-14 16:24 ` Nishanth Aravamudan
2015-09-14 23:55 ` Michael Ellerman
2015-09-15 3:43 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egi1f7t6.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).