From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB55CC433E0 for ; Fri, 31 Jul 2020 07:17:28 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6EB820829 for ; Fri, 31 Jul 2020 07:17:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6EB820829 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4BHzBG6SKSzDqbF for ; Fri, 31 Jul 2020 17:17:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=aneesh.kumar@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4BHz7Y22dWzDq7F for ; Fri, 31 Jul 2020 17:15:05 +1000 (AEST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06V72o0X073979; Fri, 31 Jul 2020 03:14:58 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 32mdgk1vgt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 31 Jul 2020 03:14:58 -0400 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 06V758jv080194; Fri, 31 Jul 2020 03:14:57 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com with ESMTP id 32mdgk1vgd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 31 Jul 2020 03:14:57 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 06V75Of9010333; Fri, 31 Jul 2020 07:14:56 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma02wdc.us.ibm.com with ESMTP id 32gcq1grff-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 31 Jul 2020 07:14:56 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 06V7Etr737880086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 31 Jul 2020 07:14:55 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1AFE112063; Fri, 31 Jul 2020 07:14:55 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C8B39112061; Fri, 31 Jul 2020 07:14:52 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.85.75.5]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 31 Jul 2020 07:14:52 +0000 (GMT) X-Mailer: emacs 27.0.91 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Vaibhav Jain , linuxppc-dev@lists.ozlabs.org, linux-nvdimm@lists.01.org Subject: Re: [PATCH v4 2/2] powerpc/papr_scm: Add support for fetching nvdimm 'fuel-gauge' metric In-Reply-To: <20200731064153.182203-3-vaibhav@linux.ibm.com> References: <20200731064153.182203-1-vaibhav@linux.ibm.com> <20200731064153.182203-3-vaibhav@linux.ibm.com> Date: Fri, 31 Jul 2020 12:44:50 +0530 Message-ID: <87ft98yx3p.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-31_02:2020-07-30, 2020-07-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=2 priorityscore=1501 mlxscore=0 clxscore=1015 phishscore=0 impostorscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007310050 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Santosh Sivaraj , Oliver O'Halloran , Vaibhav Jain , Dan Williams , Ira Weiny Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Vaibhav Jain writes: > We add support for reporting 'fuel-gauge' NVDIMM metric via > PAPR_PDSM_HEALTH pdsm payload. 'fuel-gauge' metric indicates the usage > life remaining of a papr-scm compatible NVDIMM. PHYP exposes this > metric via the H_SCM_PERFORMANCE_STATS. > > The metric value is returned from the pdsm by extending the return > payload 'struct nd_papr_pdsm_health' without breaking the ABI. A new > field 'dimm_fuel_gauge' to hold the metric value is introduced at the > end of the payload struct and its presence is indicated by by > extension flag PDSM_DIMM_HEALTH_RUN_GAUGE_VALID. > > The patch introduces a new function papr_pdsm_fuel_gauge() that is > called from papr_pdsm_health(). If fetching NVDIMM performance stats > is supported then 'papr_pdsm_fuel_gauge()' allocated an output buffer > large enough to hold the performance stat and passes it to > drc_pmem_query_stats() that issues the HCALL to PHYP. The return value > of the stat is then populated in the 'struct > nd_papr_pdsm_health.dimm_fuel_gauge' field with extension flag > 'PDSM_DIMM_HEALTH_RUN_GAUGE_VALID' set in 'struct > nd_papr_pdsm_health.extension_flags' > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Vaibhav Jain > --- > Changelog: > > v4: > * Moved a hunk from this patch to previous patch in the series. > [ Aneesh ] > > v3: > * Updated papr_pdsm_fuel_guage() to use the updated > drc_pmem_query_stats() function. > > Resend: > None > > v2: > * Restructure code in papr_pdsm_fuel_gauge() to handle error case > first [ Ira ] > * Ignore the return value of papr_pdsm_fuel_gauge() in > papr_psdm_health() [ Ira ] > --- > arch/powerpc/include/uapi/asm/papr_pdsm.h | 9 +++++ > arch/powerpc/platforms/pseries/papr_scm.c | 49 +++++++++++++++++++++++ > 2 files changed, 58 insertions(+) > > diff --git a/arch/powerpc/include/uapi/asm/papr_pdsm.h b/arch/powerpc/include/uapi/asm/papr_pdsm.h > index 9ccecc1d6840..50ef95e2f5b1 100644 > --- a/arch/powerpc/include/uapi/asm/papr_pdsm.h > +++ b/arch/powerpc/include/uapi/asm/papr_pdsm.h > @@ -72,6 +72,11 @@ > #define PAPR_PDSM_DIMM_CRITICAL 2 > #define PAPR_PDSM_DIMM_FATAL 3 > > +/* struct nd_papr_pdsm_health.extension_flags field flags */ > + > +/* Indicate that the 'dimm_fuel_gauge' field is valid */ > +#define PDSM_DIMM_HEALTH_RUN_GAUGE_VALID 1 > + > /* > * Struct exchanged between kernel & ndctl in for PAPR_PDSM_HEALTH > * Various flags indicate the health status of the dimm. > @@ -84,6 +89,7 @@ > * dimm_locked : Contents of the dimm cant be modified until CEC reboot > * dimm_encrypted : Contents of dimm are encrypted. > * dimm_health : Dimm health indicator. One of PAPR_PDSM_DIMM_XXXX > + * dimm_fuel_gauge : Life remaining of DIMM as a percentage from 0-100 > */ > struct nd_papr_pdsm_health { > union { > @@ -96,6 +102,9 @@ struct nd_papr_pdsm_health { > __u8 dimm_locked; > __u8 dimm_encrypted; > __u16 dimm_health; > + > + /* Extension flag PDSM_DIMM_HEALTH_RUN_GAUGE_VALID */ > + __u16 dimm_fuel_gauge; > }; > __u8 buf[ND_PDSM_PAYLOAD_MAX_SIZE]; > }; > diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c > index f37f3f70007d..f439f0dfea7d 100644 > --- a/arch/powerpc/platforms/pseries/papr_scm.c > +++ b/arch/powerpc/platforms/pseries/papr_scm.c > @@ -518,6 +518,51 @@ static int is_cmd_valid(struct nvdimm *nvdimm, unsigned int cmd, void *buf, > return 0; > } > > +static int papr_pdsm_fuel_gauge(struct papr_scm_priv *p, > + union nd_pdsm_payload *payload) > +{ > + int rc, size; > + u64 statval; > + struct papr_scm_perf_stat *stat; > + struct papr_scm_perf_stats *stats; > + > + /* Silently fail if fetching performance metrics isn't supported */ > + if (!p->stat_buffer_len) > + return 0; > + > + /* Allocate request buffer enough to hold single performance stat */ > + size = sizeof(struct papr_scm_perf_stats) + > + sizeof(struct papr_scm_perf_stat); > + > + stats = kzalloc(size, GFP_KERNEL); > + if (!stats) > + return -ENOMEM; > + > + stat = &stats->scm_statistic[0]; > + memcpy(&stat->stat_id, "MemLife ", sizeof(stat->stat_id)); > + stat->stat_val = 0; > + > + /* Fetch the fuel gauge and populate it in payload */ > + rc = drc_pmem_query_stats(p, stats, 1); > + if (rc < 0) { > + dev_dbg(&p->pdev->dev, "Err(%d) fetching fuel gauge\n", rc); > + goto free_stats; > + } > + > + statval = be64_to_cpu(stat->stat_val); > + dev_dbg(&p->pdev->dev, > + "Fetched fuel-gauge %llu", statval); > + payload->health.extension_flags |= > + PDSM_DIMM_HEALTH_RUN_GAUGE_VALID; > + payload->health.dimm_fuel_gauge = statval; > + > + rc = sizeof(struct nd_papr_pdsm_health); > + > +free_stats: > + kfree(stats); > + return rc; > +} > + > /* Fetch the DIMM health info and populate it in provided package. */ > static int papr_pdsm_health(struct papr_scm_priv *p, > union nd_pdsm_payload *payload) > @@ -558,6 +603,10 @@ static int papr_pdsm_health(struct papr_scm_priv *p, > > /* struct populated hence can release the mutex now */ > mutex_unlock(&p->health_mutex); > + > + /* Populate the fuel gauge meter in the payload */ > + papr_pdsm_fuel_gauge(p, payload); > + > rc = sizeof(struct nd_papr_pdsm_health); > > out: > -- > 2.26.2