From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: paulus@samba.org, Michael Neuling <mikey@neuling.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2] powerpc/TM: Disable/Enable TM looking at the ibm, pa-features device tree entry
Date: Thu, 13 Nov 2014 11:49:41 +0530 [thread overview]
Message-ID: <87fvdnvczm.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1415857347.28703.8.camel@concordia>
Michael Ellerman <mpe@ellerman.id.au> writes:
> On Wed, 2014-11-12 at 11:09 +0530, Aneesh Kumar K.V wrote:
>> Michael Neuling <mikey@neuling.org> writes:
>>
>> > On Sun, 2014-11-02 at 20:02 +0530, Aneesh Kumar K.V wrote:
>> >> Runtime disable transactional memory feature looking at pa-features
>> >> device tree entry. We need to do this so that we can run a kernel
>> >> built with TM config in PR mode.
>> >
>> > I'm happy to turn this off but why do we need to do this in PR mode?
>> > Can you explain this in the commit message.
>>
>> Hmm, that commit message needs an update. I initially did the patch for
>> P8 PR support and wanted a mechanism to disable TM. Alex added basic TM
>> support for PR mode after that. So we can drop the PR part of the
>> commit message.
>>
>> Michael Ellerman,
>>
>> Let me know if you want me to send an updated version with the those
>> part of the commit message dropped
>
> How about:
>
> powerpc: Disable CPU_FTR_TM if TM is disabled by firmware
>
> Firmware is allowed to communicate to us via the "ibm,pa-features" property
> that TM (Transactional Memory) support is disabled.
>
> Currently this doesn't happen on any platform we're aware of, but we should
> honor it anyway.
>
Looks good.
-aneesh
prev parent reply other threads:[~2014-11-13 6:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 14:32 [PATCH V2] powerpc/TM: Disable/Enable TM looking at the ibm, pa-features device tree entry Aneesh Kumar K.V
2014-11-12 0:44 ` Michael Neuling
2014-11-12 5:39 ` Aneesh Kumar K.V
2014-11-13 5:42 ` Michael Ellerman
2014-11-13 6:19 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvdnvczm.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).