From: Thomas Gleixner <tglx@linutronix.de>
To: Yicong Yang <yangyicong@huawei.com>,
catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com,
peterz@infradead.org, mpe@ellerman.id.au,
linux-arm-kernel@lists.infradead.org, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com,
pierre.gondois@arm.com, dietmar.eggemann@arm.com
Cc: yangyicong@hisilicon.com, linuxppc-dev@lists.ozlabs.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
morten.rasmussen@arm.com, msuchanek@suse.de,
gregkh@linuxfoundation.org, rafael@kernel.org,
jonathan.cameron@huawei.com, prime.zeng@hisilicon.com,
linuxarm@huawei.com, xuwei5@huawei.com, guohanjun@huawei.com
Subject: Re: [PATCH v7 1/4] cpu/SMT: Provide a default topology_is_primary_thread()
Date: Fri, 01 Nov 2024 10:31:37 +0100 [thread overview]
Message-ID: <87h68ruwp2.ffs@tglx> (raw)
In-Reply-To: <5617934d-45ac-509a-510e-d96d52a2ebf9@huawei.com>
On Fri, Nov 01 2024 at 11:18, Yicong Yang wrote:
> On 2024/10/31 21:33, Thomas Gleixner wrote:
>> cpu_smt_control is not guaranteed to have CPU_SMT_ENABLED state, so this
>> argument is bogus.
>>
> sorry for didn't explain all the cases here.
>
> For cpu_sm_control == {CPU_SMT_ENABLED, CPU_SMT_NOT_SUPPORTED, CPU_SMT_NOT_IMPLEMENTED},
> all the cpu's bootable and we won't check topology_is_primary_thread().
You don't have to copy the code to me. I'm familiar with it.
All I need is a proper explanation why your topology_is_primary_thread()
implementation is correct under all circumstances.
Thanks,
tglx
next prev parent reply other threads:[~2024-11-01 9:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 12:54 [PATCH v7 0/4] Support SMT control on arm64 Yicong Yang
2024-10-30 12:54 ` [PATCH v7 1/4] cpu/SMT: Provide a default topology_is_primary_thread() Yicong Yang
2024-10-30 14:55 ` Thomas Gleixner
2024-10-31 12:17 ` Yicong Yang
2024-10-31 13:33 ` Thomas Gleixner
2024-11-01 3:18 ` Yicong Yang
2024-11-01 9:31 ` Thomas Gleixner [this message]
2024-11-07 17:20 ` Pierre Gondois
2024-10-30 12:54 ` [PATCH v7 2/4] arch_topology: Support SMT control for OF based system Yicong Yang
2024-10-30 12:54 ` [PATCH v7 3/4] arm64: topology: Support SMT control on ACPI " Yicong Yang
2024-11-07 17:20 ` Pierre Gondois
2024-11-08 8:06 ` Yicong Yang
2024-10-30 12:54 ` [PATCH v7 4/4] arm64: Kconfig: Enable HOTPLUG_SMT Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h68ruwp2.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=peterz@infradead.org \
--cc=pierre.gondois@arm.com \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xuwei5@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).