From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6ECCC433B4 for ; Thu, 13 May 2021 09:27:18 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D54061186 for ; Thu, 13 May 2021 09:27:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D54061186 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FgmX43Qx1z3bs1 for ; Thu, 13 May 2021 19:27:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=Ofe1ObUM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=vaibhav@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=Ofe1ObUM; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FgmWX2Ynrz2xYZ for ; Thu, 13 May 2021 19:26:47 +1000 (AEST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14D9Hhpx010144; Thu, 13 May 2021 05:26:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=9uI9KP37g3URiGw0Ef0US/cyQWCmrg98bIpn0BCa6Xg=; b=Ofe1ObUMNeadXwcGvuvF2fQ00uUtl8gblGKFjLGHdGQyW3u2ligbAm2fbEMObYexJ8c/ //2DqlOmPgtUf6x9X6tOruR9NruWi4RPVJzf2m0d4Q1knoxuPeB4mlvXWIaig6Lkz3Gd UM1n1fBVQ58f8FHylrjuJ7Ij5qAq/yF62VVLpQ1ff8d2YHndTraJ0UvMOex4zJWBX1z8 kIedcwcCNBKxD8nb9XpL7thRlDl2EFZTwDfQWSwZUh9Ypd+qMGow59GJu335iPQsuE1C MS0xbAzzXwVLhL6ge4eQ/8OFkgUWStgCHzZsWVkKtsBRcM0u4uPDodjWcqp88K3fCEb4 Wg== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com with ESMTP id 38h1bvg5c5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 May 2021 05:26:40 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 14D9DBTS010432; Thu, 13 May 2021 09:26:38 GMT Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by ppma06ams.nl.ibm.com with ESMTP id 38dhwhan4q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 May 2021 09:26:38 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 14D9Qa4J22544652 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 May 2021 09:26:36 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4866142041; Thu, 13 May 2021 09:26:36 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53BDE42045; Thu, 13 May 2021 09:26:33 +0000 (GMT) Received: from vajain21.in.ibm.com (unknown [9.77.192.67]) by d06av24.portsmouth.uk.ibm.com (Postfix) with SMTP; Thu, 13 May 2021 09:26:33 +0000 (GMT) Received: by vajain21.in.ibm.com (sSMTP sendmail emulation); Thu, 13 May 2021 14:56:32 +0530 From: Vaibhav Jain To: Dan Williams Subject: Re: [PATCH v2] powerpc/papr_scm: Make 'perf_stats' invisible if perf-stats unavailable In-Reply-To: References: <20210507113948.38950-1-vaibhav@linux.ibm.com> Date: Thu, 13 May 2021 14:56:32 +0530 Message-ID: <87h7j7ass7.fsf@vajain21.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: i_Qh95vWL87N-zsL5WeL5RIVA6k1DDof X-Proofpoint-ORIG-GUID: i_Qh95vWL87N-zsL5WeL5RIVA6k1DDof X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-13_04:2021-05-12, 2021-05-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105130070 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Santosh Sivaraj , Ira Weiny , linux-nvdimm , "Aneesh Kumar K . V" , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Thanks for looking into this patch Dan, Dan Williams writes: > On Fri, May 7, 2021 at 4:40 AM Vaibhav Jain wrote: >> >> In case performance stats for an nvdimm are not available, reading the >> 'perf_stats' sysfs file returns an -ENOENT error. A better approach is >> to make the 'perf_stats' file entirely invisible to indicate that >> performance stats for an nvdimm are unavailable. >> >> So this patch updates 'papr_nd_attribute_group' to add a 'is_visible' >> callback implemented as newly introduced 'papr_nd_attribute_visible()' >> that returns an appropriate mode in case performance stats aren't >> supported in a given nvdimm. >> >> Also the initialization of 'papr_scm_priv.stat_buffer_len' is moved >> from papr_scm_nvdimm_init() to papr_scm_probe() so that it value is >> available when 'papr_nd_attribute_visible()' is called during nvdimm >> initialization. >> >> Fixes: 2d02bf835e57('powerpc/papr_scm: Fetch nvdimm performance stats from PHYP') > > Since this has been the exposed ABI since v5.9 perhaps a note / > analysis is needed here that the disappearance of this file will not > break any existing scripts/tools. > Yes, I have added a note in patch description and also updated Documentation/ABI/testing/sysfs-bus-papr-pmem with a note on when this sysfs attr would be available. Thanks for this suggestion. >> Signed-off-by: Vaibhav Jain >> --- >> Changelog: >> >> v2: >> * Removed a redundant dev_info() from pap_scm_nvdimm_init() [ Aneesh ] >> * Marked papr_nd_attribute_visible() as static which also fixed the >> build warning reported by kernel build robot >> --- >> arch/powerpc/platforms/pseries/papr_scm.c | 35 ++++++++++++++++------- >> 1 file changed, 24 insertions(+), 11 deletions(-) >> >> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c >> index e2b69cc3beaf..11e7b90a3360 100644 >> --- a/arch/powerpc/platforms/pseries/papr_scm.c >> +++ b/arch/powerpc/platforms/pseries/papr_scm.c >> @@ -907,6 +907,20 @@ static ssize_t flags_show(struct device *dev, >> } >> DEVICE_ATTR_RO(flags); >> >> +static umode_t papr_nd_attribute_visible(struct kobject *kobj, >> + struct attribute *attr, int n) >> +{ >> + struct device *dev = container_of(kobj, typeof(*dev), kobj); > > This can use the kobj_to_dev() helper. > Fixed in v3 >> + struct nvdimm *nvdimm = to_nvdimm(dev); >> + struct papr_scm_priv *p = nvdimm_provider_data(nvdimm); >> + >> + /* For if perf-stats not available remove perf_stats sysfs */ >> + if (attr == &dev_attr_perf_stats.attr && p->stat_buffer_len == 0) >> + return 0; >> + >> + return attr->mode; >> +} >> + >> /* papr_scm specific dimm attributes */ >> static struct attribute *papr_nd_attributes[] = { >> &dev_attr_flags.attr, >> @@ -916,6 +930,7 @@ static struct attribute *papr_nd_attributes[] = { >> >> static struct attribute_group papr_nd_attribute_group = { >> .name = "papr", >> + .is_visible = papr_nd_attribute_visible, >> .attrs = papr_nd_attributes, >> }; >> >> @@ -931,7 +946,6 @@ static int papr_scm_nvdimm_init(struct papr_scm_priv *p) >> struct nd_region_desc ndr_desc; >> unsigned long dimm_flags; >> int target_nid, online_nid; >> - ssize_t stat_size; >> >> p->bus_desc.ndctl = papr_scm_ndctl; >> p->bus_desc.module = THIS_MODULE; >> @@ -1016,16 +1030,6 @@ static int papr_scm_nvdimm_init(struct papr_scm_priv *p) >> list_add_tail(&p->region_list, &papr_nd_regions); >> mutex_unlock(&papr_ndr_lock); >> >> - /* Try retriving the stat buffer and see if its supported */ >> - stat_size = drc_pmem_query_stats(p, NULL, 0); >> - if (stat_size > 0) { >> - p->stat_buffer_len = stat_size; >> - dev_dbg(&p->pdev->dev, "Max perf-stat size %lu-bytes\n", >> - p->stat_buffer_len); >> - } else { >> - dev_info(&p->pdev->dev, "Dimm performance stats unavailable\n"); >> - } >> - >> return 0; >> >> err: nvdimm_bus_unregister(p->bus); >> @@ -1102,6 +1106,7 @@ static int papr_scm_probe(struct platform_device *pdev) >> u64 blocks, block_size; >> struct papr_scm_priv *p; >> const char *uuid_str; >> + ssize_t stat_size; >> u64 uuid[2]; >> int rc; >> >> @@ -1179,6 +1184,14 @@ static int papr_scm_probe(struct platform_device *pdev) >> p->res.name = pdev->name; >> p->res.flags = IORESOURCE_MEM; >> >> + /* Try retriving the stat buffer and see if its supported */ > > s/retriving/retrieving/ > Fixed in v3. >> + stat_size = drc_pmem_query_stats(p, NULL, 0); >> + if (stat_size > 0) { >> + p->stat_buffer_len = stat_size; >> + dev_dbg(&p->pdev->dev, "Max perf-stat size %lu-bytes\n", >> + p->stat_buffer_len); >> + } >> + >> rc = papr_scm_nvdimm_init(p); >> if (rc) >> goto err2; >> -- >> 2.31.1 >> > > After the minor fixups above you can add: > > Reviewed-by: Dan Williams Thanks > > ...I assume this will go through the PPC tree. Yes -- Cheers ~ Vaibhav