From: Michael Ellerman <mpe@ellerman.id.au>
To: Ghanshyam Agrawal <ghanshyam1898@gmail.com>,
mahesh@linux.ibm.com, oohall@gmail.com, npiggin@gmail.com,
christophe.leroy@csgroup.eu
Cc: linuxppc-dev@lists.ozlabs.org,
Ghanshyam Agrawal <ghanshyam1898@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: powerpc: kernel: fixed some typos
Date: Thu, 21 Dec 2023 22:25:01 +1100 [thread overview]
Message-ID: <87il4rlrw2.fsf@mail.lhotse> (raw)
In-Reply-To: <20231215115857.575697-1-ghanshyam1898@gmail.com>
Ghanshyam Agrawal <ghanshyam1898@gmail.com> writes:
> Fixed some typos
>
> Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
> ---
> arch/powerpc/kernel/eeh_pe.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Please also fix the case in arch/powerpc/include/asm/eeh.h
The subject should use the correct prefix. You can see what it should be
using:
$ git log --oneline arch/powerpc/kernel/eeh_pe.c
Please give the patch a better subject, not "some typos", tell me what
misspelling you're fixing. Same comment for the commit description.
> diff --git a/arch/powerpc/kernel/eeh_pe.c b/arch/powerpc/kernel/eeh_pe.c
> index e0ce81279624..8e0c1a8b8641 100644
> --- a/arch/powerpc/kernel/eeh_pe.c
> +++ b/arch/powerpc/kernel/eeh_pe.c
> @@ -24,10 +24,10 @@ static int eeh_pe_aux_size = 0;
> static LIST_HEAD(eeh_phb_pe);
>
> /**
> - * eeh_set_pe_aux_size - Set PE auxillary data size
> - * @size: PE auxillary data size
> + * eeh_set_pe_aux_size - Set PE auxiliary data size
> + * @size: PE auxiliary data size
While you're changing it you could also mention what the units of the
size are.
> *
> - * Set PE auxillary data size
> + * Set PE auxiliary data size
This should gain a full stop at the end of the sentence.
> */
> void eeh_set_pe_aux_size(int size)
> {
> --
> 2.25.1
cheers
next prev parent reply other threads:[~2023-12-21 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 11:58 [PATCH] arch: powerpc: kernel: fixed some typos Ghanshyam Agrawal
2023-12-15 12:07 ` Christophe Leroy
2023-12-21 11:25 ` Michael Ellerman [this message]
2023-12-22 6:19 ` Ghanshyam Agrawal
2023-12-27 0:45 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il4rlrw2.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@csgroup.eu \
--cc=ghanshyam1898@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).