From: Michael Ellerman <mpe@ellerman.id.au>
To: Joel Granados <j.granados@samsung.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
ajd@linux.ibm.com
Subject: Re: [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers
Date: Sun, 08 Oct 2023 09:28:00 +1100 [thread overview]
Message-ID: <87il7irrtb.fsf@mail.lhotse> (raw)
In-Reply-To: <20231003084749.4xxi4z64hgq5a5lw@localhost>
Joel Granados <j.granados@samsung.com> writes:
> On Mon, Oct 02, 2023 at 12:27:18PM +0000, Christophe Leroy wrote:
>> Le 02/10/2023 à 10:55, Joel Granados via B4 Relay a écrit :
>> > From: Joel Granados <j.granados@samsung.com>
>> >
> <--- snip --->
>> > - The "yesall" config saves 2432 bytes [4]
>> > - The "tiny" config saves 64 bytes [5]
>> > * memory usage:
>> > In this case there were no bytes saved because I do not have any
>> > of the drivers in the patch. To measure it comment the printk in
>> > `new_dir` and uncomment the if conditional in `new_links` [3].
>> >
>> > ---
>> > Changes in v2:
>> > - Left the dangling comma in the ctl_table arrays.
>> > - Link to v1: https://lore.kernel.org/r/20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca9f9@samsung.com
>> >
>> > Comments/feedback greatly appreciated
>>
>> Same problem on powerpc CI tests, all boot target failed, most of them
>> with similar OOPS, see
>> https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20231002-jag-sysctl_remove_empty_elem_drivers-v2-15-02dd0d46f71e@samsung.com/
> I found the culprit!. Here you are rebasing on top of v6.5.0-rc6 "INFO:
> Looking for kernel version: 6.5.0-rc6-gbf2ac4d7d596". The error makes
> sense becuase in that version we have not introduced the stopping
> criteria based on the ctl_table array size, so the loop continues
> looking for an empty sentinel past valid memory (and does not find it).
> The ctl_table check catches it but then fails to do a proper error
> because we have already tried to access invalid memory. The solution
> here is to make sure to rebase in on top of the latest rc in v6.6.
Thanks for tracking it down.
This is my fault, previously Russell would update the branch that the CI
uses as its base. Now that he has left I need to do that myself, but had
forgotten.
Sorry for the noise.
cheers
next prev parent reply other threads:[~2023-10-07 22:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 8:55 [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array Joel Granados via B4 Relay
2023-10-02 21:45 ` Phillip Potter
2023-10-02 8:55 ` [PATCH v2 02/15] hpet: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 03/15] xen: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 04/15] tty: " Joel Granados via B4 Relay
2023-10-02 8:58 ` Jiri Slaby
2023-10-02 8:55 ` [PATCH v2 05/15] scsi: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 06/15] parport: Remove the " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 07/15] macintosh: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 08/15] infiniband: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 09/15] char-misc: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 10/15] vrf: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 11/15] sgi-xp: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 12/15] fw loader: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 13/15] raid: Remove " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 14/15] Drivers: hv: " Joel Granados via B4 Relay
2023-10-02 8:55 ` [PATCH v2 15/15] intel drm: " Joel Granados via B4 Relay
2023-10-02 12:27 ` [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers Christophe Leroy
2023-10-03 8:47 ` Joel Granados
2023-10-07 22:28 ` Michael Ellerman [this message]
2023-10-09 7:08 ` Joel Granados
[not found] ` <651a84ff.050a0220.51ca9.2e91SMTPIN_ADDED_BROKEN@mx.google.com>
2023-10-02 14:17 ` [PATCH v2 10/15] vrf: Remove the now superfluous sentinel element from ctl_table array David Ahern
[not found] ` <=?utf-8?q?=3C20231002-jag-sysctl=5Fremove=5Fempty=5Felem=5Fdrive?=>
2023-10-02 14:33 ` [PATCH v2 11/15] sgi-xp: " Steve Wahl
2023-10-10 22:26 ` [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il7irrtb.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=ajd@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=j.granados@samsung.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).