From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 835F8CD54B0 for ; Tue, 19 Sep 2023 10:36:32 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=A/Qz4dVe; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RqdPW0dwTz3cNv for ; Tue, 19 Sep 2023 20:36:31 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=A/Qz4dVe; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RqdNT6RtCz2xdq for ; Tue, 19 Sep 2023 20:35:37 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1695119735; bh=XaXVz4yeLyNPYtcxciiR6RMieKxG6wAEkS00BDFRrJE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=A/Qz4dVevwY4AGsejMiiFQ0MwKv7WsEVGGC2sX0verJD1HZBGgSvc3/0PoKlrlKkI qr53abDYtPiVUtxnIWKRPBmyrz7Sv5431NkEh1GZ4SmNEBbPLbppLdIJnXA5obdXRJ 4Vsp2p8rpE28gHDDQ7VFvAuI/yEPozYCZotNVgHMb3sa7hkqRbt+Ah4H9HRKXJk7Nn QstPCtSYQKk2dseiwHLoEjMNB0rZ+qQNIQq3+Ejij1+f3OecJs4JMh/eHxFYxqNVMJ n+Gp8RVfsJBRTWD/JVJG4CK2A/ovCB7WhMFsyhaSvch91dVrV/DSUFQ3kdB2z0Zl/K BbGd1S9tVn8ug== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RqdNQ6tRfz4x2r; Tue, 19 Sep 2023 20:35:34 +1000 (AEST) From: Michael Ellerman To: Justin Stitt , Jean Delvare , Guenter Roeck , Nicholas Piggin , Christophe Leroy Subject: Re: [PATCH v2] hwmon: (ibmpowernv) refactor deprecated strncpy In-Reply-To: <20230919-strncpy-drivers-hwmon-ibmpowernv-c-v2-1-37d3e64172bc@google.com> References: <20230919-strncpy-drivers-hwmon-ibmpowernv-c-v2-1-37d3e64172bc@google.com> Date: Tue, 19 Sep 2023 20:35:34 +1000 Message-ID: <87il86tpqh.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Justin Stitt , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Justin Stitt writes: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `memcpy` as we've already precisely calculated > the number of bytes to copy while `buf` has been explicitly > zero-initialized: > | char buf[8] = { 0 }; > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Justin Stitt > --- > Changes in v2: > - prefer memcpy to strscpy (thanks Kees) > - Link to v1: https://lore.kernel.org/r/20230914-strncpy-drivers-hwmon-ibmpowernv-c-v1-1-ba6b7f42c98c@google.com > --- > drivers/hwmon/ibmpowernv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Michael Ellerman Acked-by: Michael Ellerman (powerpc) cheers