* [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10.
@ 2023-04-13 19:46 Danny Tsen
2023-04-13 19:46 ` [PATCH v2 1/2] Remove POWER10_CPU dependency Danny Tsen
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Danny Tsen @ 2023-04-13 19:46 UTC (permalink / raw)
To: linux-crypto
Cc: herbert, dtsen, nayna, linux-kernel, Danny Tsen, appro, ltcgcw,
leitao, linuxppc-dev
Remove Power10 dependency in Kconfig and detect Power10 feature at runtime.
Move PPC_MODULE_FEATURE_P10 definition to be in
arch/powerpc/include/asm/cpufeature.h.
Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
Danny Tsen (2):
Kconfig: Remove POWER10_CPU dependency.
aes-gcm-p10-glue.c, cpufeature.h: Move Power10 feature, PPC_MODULE_FEATURE_P10.
arch/powerpc/crypto/Kconfig | 2 +-
arch/powerpc/crypto/aes-gcm-p10-glue.c | 1 -
arch/powerpc/include/asm/cpufeature.h | 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 1/2] Remove POWER10_CPU dependency.
2023-04-13 19:46 [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10 Danny Tsen
@ 2023-04-13 19:46 ` Danny Tsen
2023-04-14 13:08 ` Michael Ellerman
2023-04-13 19:46 ` [PATCH v2 2/2] Move Power10 feature, PPC_MODULE_FEATURE_P10 Danny Tsen
2023-04-20 10:22 ` [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10 Herbert Xu
2 siblings, 1 reply; 7+ messages in thread
From: Danny Tsen @ 2023-04-13 19:46 UTC (permalink / raw)
To: linux-crypto
Cc: herbert, dtsen, nayna, linux-kernel, Danny Tsen, appro, ltcgcw,
leitao, linuxppc-dev
Remove Power10 dependency in Kconfig and detect Power10 feature at runtime.
Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
---
arch/powerpc/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
index 1f8f02b494e1..7113f9355165 100644
--- a/arch/powerpc/crypto/Kconfig
+++ b/arch/powerpc/crypto/Kconfig
@@ -96,7 +96,7 @@ config CRYPTO_AES_PPC_SPE
config CRYPTO_AES_GCM_P10
tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
- depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
+ depends on PPC64 && CPU_LITTLE_ENDIAN
select CRYPTO_LIB_AES
select CRYPTO_ALGAPI
select CRYPTO_AEAD
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] Remove POWER10_CPU dependency.
2023-04-13 19:46 ` [PATCH v2 1/2] Remove POWER10_CPU dependency Danny Tsen
@ 2023-04-14 13:08 ` Michael Ellerman
2023-04-14 13:29 ` Danny Tsen
0 siblings, 1 reply; 7+ messages in thread
From: Michael Ellerman @ 2023-04-14 13:08 UTC (permalink / raw)
To: Danny Tsen, linux-crypto
Cc: herbert, dtsen, nayna, linux-kernel, Danny Tsen, appro, ltcgcw,
leitao, linuxppc-dev
Danny Tsen <dtsen@linux.ibm.com> writes:
> Remove Power10 dependency in Kconfig and detect Power10 feature at runtime.
... using the existing call to module_cpu_feature_match() :)
> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
> ---
> arch/powerpc/crypto/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
> index 1f8f02b494e1..7113f9355165 100644
> --- a/arch/powerpc/crypto/Kconfig
> +++ b/arch/powerpc/crypto/Kconfig
> @@ -96,7 +96,7 @@ config CRYPTO_AES_PPC_SPE
>
> config CRYPTO_AES_GCM_P10
> tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
> - depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
> + depends on PPC64 && CPU_LITTLE_ENDIAN
> select CRYPTO_LIB_AES
> select CRYPTO_ALGAPI
> select CRYPTO_AEAD
> --
> 2.31.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] Remove POWER10_CPU dependency.
2023-04-14 13:08 ` Michael Ellerman
@ 2023-04-14 13:29 ` Danny Tsen
0 siblings, 0 replies; 7+ messages in thread
From: Danny Tsen @ 2023-04-14 13:29 UTC (permalink / raw)
To: Michael Ellerman, linux-crypto
Cc: herbert, dtsen, nayna, linux-kernel, appro, ltcgcw, leitao,
linuxppc-dev
Thanks Michael.
-Danny
On 4/14/23 8:08 AM, Michael Ellerman wrote:
> Danny Tsen <dtsen@linux.ibm.com> writes:
>> Remove Power10 dependency in Kconfig and detect Power10 feature at runtime.
> ... using the existing call to module_cpu_feature_match() :)
>
>> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
>> ---
>> arch/powerpc/crypto/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
>
> cheers
>
>> diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
>> index 1f8f02b494e1..7113f9355165 100644
>> --- a/arch/powerpc/crypto/Kconfig
>> +++ b/arch/powerpc/crypto/Kconfig
>> @@ -96,7 +96,7 @@ config CRYPTO_AES_PPC_SPE
>>
>> config CRYPTO_AES_GCM_P10
>> tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
>> - depends on PPC64 && POWER10_CPU && CPU_LITTLE_ENDIAN
>> + depends on PPC64 && CPU_LITTLE_ENDIAN
>> select CRYPTO_LIB_AES
>> select CRYPTO_ALGAPI
>> select CRYPTO_AEAD
>> --
>> 2.31.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] Move Power10 feature, PPC_MODULE_FEATURE_P10.
2023-04-13 19:46 [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10 Danny Tsen
2023-04-13 19:46 ` [PATCH v2 1/2] Remove POWER10_CPU dependency Danny Tsen
@ 2023-04-13 19:46 ` Danny Tsen
2023-04-14 13:08 ` Michael Ellerman
2023-04-20 10:22 ` [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10 Herbert Xu
2 siblings, 1 reply; 7+ messages in thread
From: Danny Tsen @ 2023-04-13 19:46 UTC (permalink / raw)
To: linux-crypto
Cc: herbert, dtsen, nayna, linux-kernel, Danny Tsen, appro, ltcgcw,
leitao, linuxppc-dev
Move Power10 feature, PPC_MODULE_FEATURE_P10, definition to be in
arch/powerpc/include/asm/cpufeature.h.
Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
---
arch/powerpc/crypto/aes-gcm-p10-glue.c | 1 -
arch/powerpc/include/asm/cpufeature.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/crypto/aes-gcm-p10-glue.c b/arch/powerpc/crypto/aes-gcm-p10-glue.c
index 1533c8cdd26f..bd3475f5348d 100644
--- a/arch/powerpc/crypto/aes-gcm-p10-glue.c
+++ b/arch/powerpc/crypto/aes-gcm-p10-glue.c
@@ -22,7 +22,6 @@
#include <linux/module.h>
#include <linux/types.h>
-#define PPC_MODULE_FEATURE_P10 (32 + ilog2(PPC_FEATURE2_ARCH_3_1))
#define PPC_ALIGN 16
#define GCM_IV_SIZE 12
diff --git a/arch/powerpc/include/asm/cpufeature.h b/arch/powerpc/include/asm/cpufeature.h
index f6f790a90367..2dcc66225e7f 100644
--- a/arch/powerpc/include/asm/cpufeature.h
+++ b/arch/powerpc/include/asm/cpufeature.h
@@ -22,6 +22,7 @@
*/
#define PPC_MODULE_FEATURE_VEC_CRYPTO (32 + ilog2(PPC_FEATURE2_VEC_CRYPTO))
+#define PPC_MODULE_FEATURE_P10 (32 + ilog2(PPC_FEATURE2_ARCH_3_1))
#define cpu_feature(x) (x)
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] Move Power10 feature, PPC_MODULE_FEATURE_P10.
2023-04-13 19:46 ` [PATCH v2 2/2] Move Power10 feature, PPC_MODULE_FEATURE_P10 Danny Tsen
@ 2023-04-14 13:08 ` Michael Ellerman
0 siblings, 0 replies; 7+ messages in thread
From: Michael Ellerman @ 2023-04-14 13:08 UTC (permalink / raw)
To: Danny Tsen, linux-crypto
Cc: herbert, dtsen, nayna, linux-kernel, Danny Tsen, appro, ltcgcw,
leitao, linuxppc-dev
Danny Tsen <dtsen@linux.ibm.com> writes:
> Move Power10 feature, PPC_MODULE_FEATURE_P10, definition to be in
> arch/powerpc/include/asm/cpufeature.h.
>
> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
> ---
> arch/powerpc/crypto/aes-gcm-p10-glue.c | 1 -
> arch/powerpc/include/asm/cpufeature.h | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
> diff --git a/arch/powerpc/crypto/aes-gcm-p10-glue.c b/arch/powerpc/crypto/aes-gcm-p10-glue.c
> index 1533c8cdd26f..bd3475f5348d 100644
> --- a/arch/powerpc/crypto/aes-gcm-p10-glue.c
> +++ b/arch/powerpc/crypto/aes-gcm-p10-glue.c
> @@ -22,7 +22,6 @@
> #include <linux/module.h>
> #include <linux/types.h>
>
> -#define PPC_MODULE_FEATURE_P10 (32 + ilog2(PPC_FEATURE2_ARCH_3_1))
> #define PPC_ALIGN 16
> #define GCM_IV_SIZE 12
>
> diff --git a/arch/powerpc/include/asm/cpufeature.h b/arch/powerpc/include/asm/cpufeature.h
> index f6f790a90367..2dcc66225e7f 100644
> --- a/arch/powerpc/include/asm/cpufeature.h
> +++ b/arch/powerpc/include/asm/cpufeature.h
> @@ -22,6 +22,7 @@
> */
>
> #define PPC_MODULE_FEATURE_VEC_CRYPTO (32 + ilog2(PPC_FEATURE2_VEC_CRYPTO))
> +#define PPC_MODULE_FEATURE_P10 (32 + ilog2(PPC_FEATURE2_ARCH_3_1))
>
> #define cpu_feature(x) (x)
>
> --
> 2.31.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10.
2023-04-13 19:46 [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10 Danny Tsen
2023-04-13 19:46 ` [PATCH v2 1/2] Remove POWER10_CPU dependency Danny Tsen
2023-04-13 19:46 ` [PATCH v2 2/2] Move Power10 feature, PPC_MODULE_FEATURE_P10 Danny Tsen
@ 2023-04-20 10:22 ` Herbert Xu
2 siblings, 0 replies; 7+ messages in thread
From: Herbert Xu @ 2023-04-20 10:22 UTC (permalink / raw)
To: Danny Tsen
Cc: dtsen, nayna, linux-kernel, appro, linux-crypto, ltcgcw, leitao,
linuxppc-dev
On Thu, Apr 13, 2023 at 03:46:23PM -0400, Danny Tsen wrote:
> Remove Power10 dependency in Kconfig and detect Power10 feature at runtime.
> Move PPC_MODULE_FEATURE_P10 definition to be in
> arch/powerpc/include/asm/cpufeature.h.
>
> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
>
> Danny Tsen (2):
> Kconfig: Remove POWER10_CPU dependency.
> aes-gcm-p10-glue.c, cpufeature.h: Move Power10 feature, PPC_MODULE_FEATURE_P10.
>
> arch/powerpc/crypto/Kconfig | 2 +-
> arch/powerpc/crypto/aes-gcm-p10-glue.c | 1 -
> arch/powerpc/include/asm/cpufeature.h | 1 +
> 3 files changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.31.1
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-04-20 10:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-13 19:46 [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10 Danny Tsen
2023-04-13 19:46 ` [PATCH v2 1/2] Remove POWER10_CPU dependency Danny Tsen
2023-04-14 13:08 ` Michael Ellerman
2023-04-14 13:29 ` Danny Tsen
2023-04-13 19:46 ` [PATCH v2 2/2] Move Power10 feature, PPC_MODULE_FEATURE_P10 Danny Tsen
2023-04-14 13:08 ` Michael Ellerman
2023-04-20 10:22 ` [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10 Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).