From: Nathan Lynch <nathanl@linux.ibm.com>
To: Haren Myneni <haren@linux.ibm.com>,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com
Subject: Re: [PATCH v2 1/4] powerpc/pseries/vas: Define global hv_cop_caps struct
Date: Tue, 08 Feb 2022 09:48:34 -0600 [thread overview]
Message-ID: <87iltps6jx.fsf@linux.ibm.com> (raw)
In-Reply-To: <9ffeb5567b2836ee8326d530310e4eb4f6f9f1f2.camel@linux.ibm.com>
Haren Myneni <haren@linux.ibm.com> writes:
> The coprocessor capabilities struct is used to get default and
> QoS capabilities from the hypervisor during init, DLPAR event and
> migration. So instead of allocating this struct for each event,
> define global struct and reuse it, especially eliminate memory
> allocation failure during migration.
Which allows the migration code to avoid adding an error path. I could
go either way, but this approach seems fine to me assuming all users of
the global object are guarded by an appropriate lock.
Acked-by: Nathan Lynch <nathanl@linux.ibm.com>
next prev parent reply other threads:[~2022-02-08 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 2:25 [PATCH v2 0/4] powerpc/pseries/vas: VAS/NXGZIP support with LPM Haren Myneni
2022-02-06 2:27 ` [PATCH v2 1/4] powerpc/pseries/vas: Define global hv_cop_caps struct Haren Myneni
2022-02-08 15:48 ` Nathan Lynch [this message]
2022-02-08 16:00 ` Haren Myneni
2022-02-06 2:28 ` [PATCH v2 2/4] powerpc/pseries/vas: Modify reconfig open/close functions for migration Haren Myneni
2022-02-06 2:28 ` [PATCH v2 3/4] powerpc/pseries/vas: Add VAS migration handler Haren Myneni
2022-02-06 2:29 ` [PATCH v2 4/4] powerpc/pseries/vas: Disable window open during migration Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iltps6jx.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=haren@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).