From: Michael Ellerman <michaele@au1.ibm.com>
To: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Ram Pai <linuxram@us.ibm.com>,
linux-kernel@vger.kernel.org,
Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>
Subject: Re: [PATCH] powerpc/pseries/svm: Fixup align argument in alloc_shared_lppaca() function
Date: Wed, 10 Jun 2020 21:21:49 +1000 [thread overview]
Message-ID: <87imfzf9o2.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200609113909.17236-1-sathnaga@linux.vnet.ibm.com>
Satheesh Rajendran <sathnaga@linux.vnet.ibm.com> writes:
> Argument "align" in alloc_shared_lppaca() function was unused inside the
> function. Let's fix it and update code comment.
I think it would be better to drop the align argument entirely and keep
that logic, and the comment, internal to alloc_shared_lppaca().
cheers
prev parent reply other threads:[~2020-06-10 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 11:39 [PATCH] powerpc/pseries/svm: Fixup align argument in alloc_shared_lppaca() function Satheesh Rajendran
2020-06-10 4:19 ` Thiago Jung Bauermann
2020-06-10 11:21 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imfzf9o2.fsf@mpe.ellerman.id.au \
--to=michaele@au1.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=sathnaga@linux.vnet.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).