linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Lynch <nathanl@linux.ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: Vaibhav Jain <vaibhav@linux.ibm.com>,
	paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
	npiggin@gmail.com
Subject: Re: ["RFC PATCH" 1/2] powerpc/mm: Fix node look up with numa=off boot
Date: Mon, 01 Jul 2019 11:42:29 -0500	[thread overview]
Message-ID: <87imslso3u.fsf@linux.ibm.com> (raw)
In-Reply-To: <1329fd62-c2ad-f2c9-d3df-731f543dd3ea@linux.ibm.com>

"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:
> I guess we should have here.
>
> modified   arch/powerpc/mm/numa.c
> @@ -416,12 +416,11 @@ static int of_get_assoc_arrays(struct assoc_arrays 
> *aa)
>   static int of_drconf_to_nid_single(struct drmem_lmb *lmb)
>   {
>   	struct assoc_arrays aa = { .arrays = NULL };
> -	/* is that correct? */
>   	int default_nid = 0;
>   	int nid = default_nid;
>   	int rc, index;
>
> -	if (!numa_enabled)
> +	if ((min_common_depth < 0) || !numa_enabled)
>   		return NUMA_NO_NODE;
>
>   	rc = of_get_assoc_arrays(&aa);
>
>
> Nathan,
>
> Can you check this?

Looks like it would do the right thing.

Just checking: do people still need numa=off? Seems like it's a
maintenance burden :-)

  reply	other threads:[~2019-07-01 16:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-29  8:36 ["RFC PATCH" 1/2] powerpc/mm: Fix node look up with numa=off boot Aneesh Kumar K.V
2019-06-29  8:36 ` ["RFC PATCH" 2/2] powerpc/mm: Conslidate numa_enable check and min_common_depth check Aneesh Kumar K.V
2019-06-29  9:06   ` Aneesh Kumar K.V
2019-06-29 15:39   ` Vaibhav Jain
2019-06-29 15:54     ` Aneesh Kumar K.V
2019-06-29  9:03 ` ["RFC PATCH" 1/2] powerpc/mm: Fix node look up with numa=off boot Aneesh Kumar K.V
2019-07-01 16:42   ` Nathan Lynch [this message]
2019-07-02  2:45     ` Aneesh Kumar K.V
2019-07-02 15:57       ` Nathan Lynch
2019-07-04 14:29         ` Michael Ellerman
2019-07-09 14:56           ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imslso3u.fsf@linux.ibm.com \
    --to=nathanl@linux.ibm.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    --cc=vaibhav@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).