From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42Kj760wW5zF3Jl for ; Wed, 26 Sep 2018 12:48:33 +1000 (AEST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8Q2dHRL087548 for ; Tue, 25 Sep 2018 22:48:32 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mr052jub4-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 25 Sep 2018 22:48:31 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Sep 2018 03:48:29 +0100 From: "Aneesh Kumar K.V" To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , aneesh.kumar@linux.vnet.ibm.com Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v5 18/22] powerpc/mm: Extend pte_fragment functionality to nohash/32 In-Reply-To: References: Date: Wed, 26 Sep 2018 08:18:22 +0530 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87in2tgeix.fsf@linux.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Christophe Leroy writes: > In order to allow the 8xx to handle pte_fragments, this patch > extends the use of pte_fragments to nohash/32 platforms. > > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/mmu_context.h | 2 +- > arch/powerpc/include/asm/nohash/32/mmu-40x.h | 1 + > arch/powerpc/include/asm/nohash/32/mmu-44x.h | 1 + > arch/powerpc/include/asm/nohash/32/mmu-8xx.h | 1 + > arch/powerpc/include/asm/nohash/32/mmu.h | 4 ++- > arch/powerpc/include/asm/nohash/32/pgalloc.h | 52 +++++++++++++--------------- > arch/powerpc/include/asm/nohash/32/pgtable.h | 11 ++++-- > arch/powerpc/include/asm/nohash/mmu-book3e.h | 1 + > arch/powerpc/mm/Makefile | 3 ++ > arch/powerpc/mm/mmu_context_nohash.c | 14 ++++++++ > 10 files changed, 57 insertions(+), 33 deletions(-) > > diff --git a/arch/powerpc/include/asm/mmu_context.h b/arch/powerpc/include/asm/mmu_context.h > index b2f89b621b15..7f2c37a3f99d 100644 > --- a/arch/powerpc/include/asm/mmu_context.h > +++ b/arch/powerpc/include/asm/mmu_context.h > @@ -222,7 +222,7 @@ static inline int arch_dup_mmap(struct mm_struct *oldmm, > return 0; > } > > -#ifndef CONFIG_PPC_BOOK3S_64 > +#if defined(CONFIG_PPC_BOOK3E_64) || defined(CONFIG_PPC_BOOK3S_32) > static inline void arch_exit_mmap(struct mm_struct *mm) > { > } Can we do that with #ifndef arch_exit_mmap? This should handle every platform that doesn't use pte_frag right? > diff --git a/arch/powerpc/include/asm/nohash/32/mmu-40x.h b/arch/powerpc/include/asm/nohash/32/mmu-40x.h > index 74f4edb5916e..7c77ceed71d6 100644 > --- a/arch/powerpc/include/asm/nohash/32/mmu-40x.h > +++ b/arch/powerpc/include/asm/nohash/32/mmu-40x.h > @@ -58,6 +58,7 @@ typedef struct { > unsigned int id; > unsigned int active; > unsigned long vdso_base; -aneesh