From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.atmark-techno.com (shop.atmark-techno.com [210.191.215.173]) by ozlabs.org (Postfix) with ESMTP id 7D1656838D for ; Sat, 1 Oct 2005 06:34:15 +1000 (EST) Date: Sat, 01 Oct 2005 05:02:17 +0900 Message-ID: <87irwifho6.wl@mail2.atmark-techno.com> From: Yasushi SHOJI To: linuxppc-dev@ozlabs.org MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Subject: where should readb based/platform specific memcpy_fromio() be? List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello, I'd like to add a variant of memcpy_fromio() for 16bit bus. In-tree implementations seem to me that most, if not all, arch have either readb() or memcpy() based mempy_fromio. powerpc doesn't currently have readb() based. I assume that means all ppc boards are 32bit clean. if I'd like merge this readb() based or optimized for 16bit bus version, where should I put it? obviously I have to add ifdef in include/asm-ppc/io.h, but should I do either: - add extern in io.h and body under platform/..../xxxx.c - add extern in io.h and body under arch/ppc/lib/io.c - add static inline version in io.h - add static inline version in platform/..../xxxxx.h which is included from asm-ppc/io.h regards, -- yashi