From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD013C001DF for ; Fri, 7 Jul 2023 13:41:26 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G/uACz5Z; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G/uACz5Z; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QyF11155cz3cBG for ; Fri, 7 Jul 2023 23:41:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G/uACz5Z; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G/uACz5Z; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=fmartine@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QyDzz1QK6z2xHK for ; Fri, 7 Jul 2023 23:40:30 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688737226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eSLQOQX2Flx1G07KYazrMVvBAcWU6hFPEM6DlSyIig8=; b=G/uACz5ZMYyUiBErHIFDax28DghqIzhNdXg9hD2UX3+2ZAdpZhDSwCYiENc5NKQsrCSYkY pRAyDCVNqQLnsPZqG7gp8JjuN62Y7fATqb9sdDf/GtYHfW8aaG7c2r0a5RxAATckEYop3O FBmJ8tsnHWG9swbK2UKdSBOQB7GAQbw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688737226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eSLQOQX2Flx1G07KYazrMVvBAcWU6hFPEM6DlSyIig8=; b=G/uACz5ZMYyUiBErHIFDax28DghqIzhNdXg9hD2UX3+2ZAdpZhDSwCYiENc5NKQsrCSYkY pRAyDCVNqQLnsPZqG7gp8JjuN62Y7fATqb9sdDf/GtYHfW8aaG7c2r0a5RxAATckEYop3O FBmJ8tsnHWG9swbK2UKdSBOQB7GAQbw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-eT1MkR-yPUGx32Y7AReiJg-1; Fri, 07 Jul 2023 09:40:24 -0400 X-MC-Unique: eT1MkR-yPUGx32Y7AReiJg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3142665f122so965004f8f.0 for ; Fri, 07 Jul 2023 06:40:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688737223; x=1691329223; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eSLQOQX2Flx1G07KYazrMVvBAcWU6hFPEM6DlSyIig8=; b=hqwMkq6oOKqArC7mBeV8GpCLBrilvdqIED0pw0rOU1d9tj6pzfkUZi3iotanbaCcuO TUvG6p87Xsz6ff1b5De8p4NxucxV1ExPKfDmQr0UxiHhi0e2E5KKBi4j0qpm9uSd7n6e ZqaTsDHIU8EqSNqI/+ZWSYagqk5FfrllOBfZQprdYaD0HJ7q/VBD5s4+trtNAWk7V70h JuuLHsa4gKex5AUVD+glGq1hslVEy1rJJKm9QbmpQBI+H22kVJVk5EgPoqLPy6/PHSVR oUtjHt91la2AHk0cAZ9aAA4taAVbXahzV2zPTtLgi909xvCnzKIJUWG2JLApYsiSHdrf tM4w== X-Gm-Message-State: ABy/qLb3jRymiIZrPnlNlFf9J/+CYdwkqmqHyKo9PK5lhdsql93XEFNW QzvSU2Ek+UzQ/MhetMyczgAkSwZ4sMsW7hJk5PGrf7IZuy52kaejAcFx4HR20QWPX1OTggUlcYw aNbIhI9RWWZrV07aDfTvZEtDIww== X-Received: by 2002:adf:fd84:0:b0:314:2c7a:d100 with SMTP id d4-20020adffd84000000b003142c7ad100mr3491302wrr.42.1688737223526; Fri, 07 Jul 2023 06:40:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlGembFVs9w4+Nx6kwExMzgs9gyKSxG86BN2Jn1gUhGo+dJC0cQ0C5x3R9/Olki3X8v+sW6RJQ== X-Received: by 2002:adf:fd84:0:b0:314:2c7a:d100 with SMTP id d4-20020adffd84000000b003142c7ad100mr3491295wrr.42.1688737223237; Fri, 07 Jul 2023 06:40:23 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id x4-20020a5d60c4000000b003112ab916cdsm4482161wrt.73.2023.07.07.06.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 06:40:23 -0700 (PDT) From: Javier Martinez Canillas To: Arnd Bergmann , Thomas Zimmermann Subject: Re: [PATCH 2/4] vgacon: rework screen_info #ifdef checks In-Reply-To: <20230707095415.1449376-2-arnd@kernel.org> References: <20230707095415.1449376-1-arnd@kernel.org> <20230707095415.1449376-2-arnd@kernel.org> Date: Fri, 07 Jul 2023 15:40:22 +0200 Message-ID: <87jzvbyh4p.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, linux-ia64@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, WANG Xuerui , Ard Biesheuvel , Helge Deller , Huacai Chen , Russell King , Matt Turner , Albert Ou , Arnd Bergmann , Richard Henderson , Nicholas Piggin , Ivan Kokshaysky , loongarch@lists.linux.dev, Paul Walmsley , Thomas Bogendoerfer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Arnd Bergmann writes: > From: Arnd Bergmann > > On non-x86 architectures, the screen_info variable is generally only > used for the VGA console where supported, and in some cases the EFI > framebuffer or vga16fb. > > Now that we have a definite list of which architectures actually use it > for what, use consistent #ifdef checks so the global variable is only > defined when it is actually used on those architectures. > > On powerpc, there is no support for vgacon, but there is support for > vga16fb. Loongarch and riscv have no support for vgacon or vga16fb, but > they support EFI firmware, so only that needs to be checked, and the > initialization can be removed because that is handled by EFI. > IA64 has both vgacon and EFI. > > Signed-off-by: Arnd Bergmann > --- [...] > diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c > index 5a55ac82c13a4..0c09ff7fde46b 100644 > --- a/arch/ia64/kernel/setup.c > +++ b/arch/ia64/kernel/setup.c > @@ -86,9 +86,11 @@ EXPORT_SYMBOL(local_per_cpu_offset); > #endif > unsigned long ia64_cycles_per_usec; > struct ia64_boot_param *ia64_boot_param; > +#if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_EFI) > struct screen_info screen_info; I think that only screen_info should be guarded by both symbols ? > unsigned long vga_console_iobase; It seems this variable was never used since it was introduced by commit 66b7f8a30437 ("[IA64-SGI] pcdp: add PCDP pci interface support") ? > unsigned long vga_console_membase; And this is only used by mdacon (not supported by ia64), vgacon and vga16fb (not supported by ia64 either). So this could just be guarded just by CONFIG_VGA_CONSOLE for ia64 ? The rest of the patch looks good to me. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat