From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE3A0EB64D7 for ; Tue, 20 Jun 2023 13:17:17 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=Ssj75aD4; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QlnGz63s2z3bYj for ; Tue, 20 Jun 2023 23:17:15 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=Ssj75aD4; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QlnG11nD3z30Xd for ; Tue, 20 Jun 2023 23:16:25 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QlnFz3jyRz4x1R; Tue, 20 Jun 2023 23:16:23 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1687266985; bh=62smsxlJDZU6Jbl2/hF7KMwX/Cu2CFdidOWYdCKWjFE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ssj75aD4vUP5RbyiHK8fMOI3r0apZCkh2rqk4TO7hurs6P4Frh1h4d0J8ZBj8Ghpl 9/ZgRf+/oEL+yBxFPat/XRXEzIliUwDd/FjrD9eZzw8M+WXo0LVD+eP7CFmrLi2tUU e8X2PKFzMsD+3sCBmFueLheFJpAgA+m21T0Csyti9tLfCa2DDDSuEsiRG3zdQ3yfiO WXyoafCGsyjYvY7hbxirWLigdV1g+PsGiiWCr4TuuIawpJC9F6hpm9xbhN9mQL3CRY y3HmlASqYWozd8nMftTBVLlUZ0GIECoyKSuBPjFj8j8u3DjYSjbEO5uk56Mn2vdFzo rBDWqb7ehHEcA== From: Michael Ellerman To: Joel Stanley , linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH 2/3] powerpc/pci: Remove MVE code In-Reply-To: <20230613045202.294451-3-joel@jms.id.au> References: <20230613045202.294451-1-joel@jms.id.au> <20230613045202.294451-3-joel@jms.id.au> Date: Tue, 20 Jun 2023 23:16:19 +1000 Message-ID: <87jzvyp93w.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , oohall@gmail.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Joel Stanley writes: > With IODA1 support gone the OPAL calls to set MVE are dead code. Remove > them. > > TODO: Do we have rules for removing unused OPAL APIs? Should we leave it > in opal.h? opal-call.c? I don't think we have any rules for removal. When skiboot was being actively developed Stewart and I did try to keep the skiboot and kernel opal-api.h in sync, but I haven't checked on the state of that for a few years. ... And I just checked and boy they are *not* in sync anymore. But anyway opal.h and opal-call.c are just kernel internal, so I think we just remove unused code there as normal. cheers