From: Michael Ellerman <mpe@ellerman.id.au>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linuxppc-dev@ozlabs.org, torvalds@linux-foundation.org,
ruscur@russell.cc, bryantly@linux.vnet.ibm.com,
jjalvare@linux.vnet.ibm.com
Subject: Re: [PATCH] PCI/AER: Move pci_uevent_ers() out of pci.h
Date: Fri, 23 Feb 2018 15:09:32 +1100 [thread overview]
Message-ID: <87k1v4pcsj.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180222231251.GC14632@bhelgaas-glaptop.roam.corp.google.com>
Bjorn Helgaas <helgaas@kernel.org> writes:
> On Thu, Feb 08, 2018 at 11:20:35PM +1100, Michael Ellerman wrote:
>> There's no reason pci_uevent_ers() needs to be inline in pci.h, so
>> move it out to a C file.
>>
>> Given it's used by AER the obvious location would be somewhere in
>> drivers/pci/pcie/aer, but because it's also used by powerpc EEH code
>> unfortunately that doesn't work in the case where EEH is enabled but
>> PCIEPORTBUS is not.
>>
>> So for now put it in pci-driver.c, next to pci_uevent(), with an
>> appropriate #ifdef so it's not built if AER and EEH are both disabled.
>>
>> While we're moving it also fix up the kernel doc comment for @pdev to
>> be accurate.
>>
>> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Applied to pci/aer for v4.17, thanks!
Thanks.
cheers
prev parent reply other threads:[~2018-02-23 4:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 12:20 [PATCH] PCI/AER: Move pci_uevent_ers() out of pci.h Michael Ellerman
2018-02-08 15:05 ` Bryant G. Ly
2018-02-22 23:12 ` Bjorn Helgaas
2018-02-23 4:10 ` Michael Ellerman
2018-02-23 14:38 ` Bryant G. Ly
2018-02-22 23:12 ` Bjorn Helgaas
2018-02-23 4:09 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1v4pcsj.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=bhelgaas@google.com \
--cc=bryantly@linux.vnet.ibm.com \
--cc=helgaas@kernel.org \
--cc=jjalvare@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ruscur@russell.cc \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox