From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yLCm15pYwzDqkj for ; Mon, 23 Oct 2017 21:47:45 +1100 (AEDT) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9NAiQlD137792 for ; Mon, 23 Oct 2017 06:47:42 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 2dsa7nkved-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 23 Oct 2017 06:47:42 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Oct 2017 11:47:41 +0100 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v9NAlaiJ28180732 for ; Mon, 23 Oct 2017 10:47:37 GMT Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v9NAlQA4019111 for ; Mon, 23 Oct 2017 21:47:27 +1100 From: "Aneesh Kumar K.V" To: Balbir Singh , Ram Pai Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org, paulus@samba.org, khandual@linux.vnet.ibm.com, hbabu@us.ibm.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, ebiederm@xmission.com Subject: Re: [PATCH 06/25] powerpc: cleaup AMR, iAMR when a key is allocated or freed In-Reply-To: <20171018143414.125b6e0f@firefly.ozlabs.ibm.com> References: <1504910713-7094-1-git-send-email-linuxram@us.ibm.com> <1504910713-7094-15-git-send-email-linuxram@us.ibm.com> <20171018143414.125b6e0f@firefly.ozlabs.ibm.com> Date: Mon, 23 Oct 2017 15:13:45 +0530 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87k1zm8ai6.fsf@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Balbir Singh writes: > On Fri, 8 Sep 2017 15:44:54 -0700 > Ram Pai wrote: > >> cleanup the bits corresponding to a key in the AMR, and IAMR >> register, when the key is newly allocated/activated or is freed. >> We dont want some residual bits cause the hardware enforce >> unintended behavior when the key is activated or freed. >> >> Signed-off-by: Ram Pai >> --- >> arch/powerpc/include/asm/pkeys.h | 12 ++++++++++++ >> 1 files changed, 12 insertions(+), 0 deletions(-) >> >> diff --git a/arch/powerpc/include/asm/pkeys.h b/arch/powerpc/include/asm/pkeys.h >> index 5a83ed7..53bf13b 100644 >> --- a/arch/powerpc/include/asm/pkeys.h >> +++ b/arch/powerpc/include/asm/pkeys.h >> @@ -54,6 +54,8 @@ static inline bool mm_pkey_is_allocated(struct mm_struct *mm, int pkey) >> mm_set_pkey_is_allocated(mm, pkey)); >> } >> >> +extern void __arch_activate_pkey(int pkey); >> +extern void __arch_deactivate_pkey(int pkey); >> /* >> * Returns a positive, 5-bit key on success, or -1 on failure. >> */ >> @@ -80,6 +82,12 @@ static inline int mm_pkey_alloc(struct mm_struct *mm) >> >> ret = ffz((u32)mm_pkey_allocation_map(mm)); >> mm_set_pkey_allocated(mm, ret); >> + >> + /* >> + * enable the key in the hardware >> + */ >> + if (ret > 0) >> + __arch_activate_pkey(ret); >> return ret; >> } >> >> @@ -91,6 +99,10 @@ static inline int mm_pkey_free(struct mm_struct *mm, int pkey) >> if (!mm_pkey_is_allocated(mm, pkey)) >> return -EINVAL; >> >> + /* >> + * Disable the key in the hardware >> + */ >> + __arch_deactivate_pkey(pkey); >> mm_set_pkey_free(mm, pkey); >> >> return 0; > > I think some of these patches can be merged, too much fine granularity > is hurting my ability to see the larger function/implementation. Completely agree -aneesh