From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp06.in.ibm.com (e28smtp06.in.ibm.com [122.248.162.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e28smtp06.in.ibm.com", Issuer "GeoTrust SSL CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 924BA2C04F7 for ; Mon, 30 Sep 2013 22:57:59 +1000 (EST) Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 30 Sep 2013 18:27:56 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 55251394004D for ; Mon, 30 Sep 2013 18:27:37 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8UD0EtM41091112 for ; Mon, 30 Sep 2013 18:30:15 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8UCvq34023536 for ; Mon, 30 Sep 2013 18:27:52 +0530 From: "Aneesh Kumar K.V" To: Alexander Graf Subject: Re: [RFC PATCH 08/11] kvm: powerpc: book3s: Support building HV and PR KVM as module In-Reply-To: <9CCFAB0B-A05C-4C70-AA87-6339D1BA1471@suse.de> References: <1380276233-17095-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1380276233-17095-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <32B8402B-25D1-41F4-A3FB-B945B72EDC4C@suse.de> <87txh69ztz.fsf@linux.vnet.ibm.com> <9CCFAB0B-A05C-4C70-AA87-6339D1BA1471@suse.de> Date: Mon, 30 Sep 2013 18:27:51 +0530 Message-ID: <87k3hybh68.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Alexander Graf writes: > On 27.09.2013, at 15:08, Aneesh Kumar K.V wrote: > >> Alexander Graf writes: >> >>> On 27.09.2013, at 12:03, Aneesh Kumar K.V wrote: >>> >>>> diff --git a/arch/powerpc/kvm/book3s_64_mmu_host.c b/arch/powerpc/kvm/book3s_64_mmu_host.c >>>> index fd5b393..775d368 100644 >>>> --- a/arch/powerpc/kvm/book3s_64_mmu_host.c >>>> +++ b/arch/powerpc/kvm/book3s_64_mmu_host.c >>>> @@ -27,6 +27,7 @@ >>>> #include >>>> #include >>>> #include >>>> + >>> >>> Stray whitespace change >>> >> >> will fix >> >>>> #include "trace_pr.h" >>>> >>>> #define PTE_SIZE 12 >>>> diff --git a/arch/powerpc/kvm/book3s_emulate.c b/arch/powerpc/kvm/book3s_emulate.c >>>> index b9841ad..20d03c2 100644 >>>> --- a/arch/powerpc/kvm/book3s_emulate.c >>>> +++ b/arch/powerpc/kvm/book3s_emulate.c >>>> @@ -172,7 +172,7 @@ int kvmppc_core_emulate_op_pr(struct kvm_run *run, struct kvm_vcpu *vcpu, >>>> vcpu->arch.mmu.tlbie(vcpu, addr, large); >>>> break; >>>> } >>>> -#ifdef CONFIG_KVM_BOOK3S_64_PR >>>> +#ifdef CONFIG_KVM_BOOK3S_PR >>> >>> Why? >> >> If i have CONFIG_KVM_BOOK3S_64_PR=m #ifdef CONFIG_KVM_BOOK3S_64_PR will >> not work. There is a runtime check I can use IS_ENABLED(). But didn't >> want to do those. Hence moved to the symbol which will be set as >> CONFIG_KVM_BOOK3S_PR = y > > Ah, I see. The naming starts to get really confusing. Could you please > give this a slightly better name, such as > CONFIG_KVM_BOOK3S_PR_POSSIBLE or such, so that it's obvious that this > #ifdef doesn't mean "option is enabled", but instead means "option can > potentially be enabled through a module". Will do -aneesh