From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73D89EEAA7A for ; Fri, 15 Sep 2023 00:44:57 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=KLdOsoMc; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RmwSl518Mz3cKc for ; Fri, 15 Sep 2023 10:44:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=KLdOsoMc; dkim-atps=neutral Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RmwRl3sSwz3bT8 for ; Fri, 15 Sep 2023 10:44:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1694738641; bh=A2yKheXXYeVxgUYqKY0JwuarOyyrLHHqN46l251F9L0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KLdOsoMcXyPwJu7oy1hyRJvAzVA4MSQG8jN/N0hWl2RA8KGiWWCHGx5+mltwGIety 4TFaQCSjeOwQidv7aFM+mkBpP6zgOTHuqrOvE+5naIiZtKjHpKv7BSEpXQg9NnmzC8 F1IFQGGelU17mPoCRvPX+kyIZ6J3bRuHv802PzGro/RYpsiGuDes9t9A2Dw1cKEzM2 UfZ4FE4OFnrBh3BbRtCor//9DmNHmssOnMN/7eUe02mJD3qM+IyxXmFu1d26lLKwI6 Pwb7InIsfO2UK5xK33EVSk9iZd/4bQCjOQJQnG11F/Hj6nBlipabBAmi/T1H9D56oK vuJXqqMRR6ZBQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4RmwRj26nkz4x3D; Fri, 15 Sep 2023 10:44:01 +1000 (AEST) From: Michael Ellerman To: Christophe Leroy , Nicholas Piggin Subject: Re: [PATCH] powerpc/82xx: Select FSL_SOC In-Reply-To: <7ab513546148ebe33ddd4b0ea92c7bfd3cce3ad7.1694705016.git.christophe.leroy@csgroup.eu> References: <7ab513546148ebe33ddd4b0ea92c7bfd3cce3ad7.1694705016.git.christophe.leroy@csgroup.eu> Date: Fri, 15 Sep 2023 10:43:57 +1000 Message-ID: <87led86zaq.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Randy Dunlap , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Christophe Leroy writes: > It used to be impossible to select CONFIG_CPM2 without selecting > CONFIG_FSL_SOC at the same time because CONFIG_CPM2 was dependent > on CONFIG_8260 and CONFIG_8260 was selecting CONFIG_FSL_SOC. > > But after commit eb5aa2137275 ("powerpc/82xx: Remove CONFIG_8260 > and CONFIG_8272") CONFIG_CPM2 depends on CONFIG_MPC82xx instead ^ CONFIG_PPC_82xx All the references to CONFIG_MPC82xx should be CONFIG_PPC_82xx right? I can update when applying. cheers > but CONFIG_MPC82xx doesn't directly selects CONFIG_FSL_SOC. > > Fix it by forcing CONFIG_MPC82xx to select CONFIG_FSL_SOC just > like already done by MPC8xx, MPC512x, MPC83xx, PPC_86xx. > > Reported-by: Randy Dunlap > Fixes: eb5aa2137275 ("powerpc/82xx: Remove CONFIG_8260 and CONFIG_8272") > Signed-off-by: Christophe Leroy > --- > arch/powerpc/platforms/82xx/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/platforms/82xx/Kconfig b/arch/powerpc/platforms/82xx/Kconfig > index d9f1a2a83158..1824536cf6f2 100644 > --- a/arch/powerpc/platforms/82xx/Kconfig > +++ b/arch/powerpc/platforms/82xx/Kconfig > @@ -2,6 +2,7 @@ > menuconfig PPC_82xx > bool "82xx-based boards (PQ II)" > depends on PPC_BOOK3S_32 > + select FSL_SOC > > if PPC_82xx > > @@ -9,7 +10,6 @@ config EP8248E > bool "Embedded Planet EP8248E (a.k.a. CWH-PPC-8248N-VE)" > select CPM2 > select PPC_INDIRECT_PCI if PCI > - select FSL_SOC > select PHYLIB if NETDEVICES > select MDIO_BITBANG if PHYLIB > help > @@ -22,7 +22,6 @@ config MGCOGE > bool "Keymile MGCOGE" > select CPM2 > select PPC_INDIRECT_PCI if PCI > - select FSL_SOC > help > This enables support for the Keymile MGCOGE board. > > -- > 2.41.0