* [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
@ 2005-12-03 19:07 Otavio Salvador
2005-12-03 21:24 ` Eugene Surovegin
0 siblings, 1 reply; 8+ messages in thread
From: Otavio Salvador @ 2005-12-03 19:07 UTC (permalink / raw)
To: linuxppc-dev, akpm; +Cc: Otavio Salvador
The prototype of btext_init function was missing and then caused a compile
warning.
---
include/asm-ppc/btext.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applies-to: 60e8ae37378de2772b6b0768b12a49f923710152
786b869f9cfd4c1f82fbc8b20fa8cafb9188e12f
diff --git a/include/asm-ppc/btext.h b/include/asm-ppc/btext.h
index ccaefab..2329331 100644
--- a/include/asm-ppc/btext.h
+++ b/include/asm-ppc/btext.h
@@ -18,6 +18,7 @@ extern boot_infos_t disp_bi;
extern int boot_text_mapped;
extern void init_boot_display(void);
+extern void __init btext_init(boot_infos_t *bi);
extern void btext_welcome(void);
extern void btext_prepare_BAT(void);
extern void btext_setup_display(int width, int height, int depth, int pitch,
---
0.99.9k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
2005-12-03 19:07 [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function Otavio Salvador
@ 2005-12-03 21:24 ` Eugene Surovegin
2005-12-03 21:31 ` Otavio Salvador
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Eugene Surovegin @ 2005-12-03 21:24 UTC (permalink / raw)
To: Otavio Salvador; +Cc: akpm, linuxppc-dev
On Sat, Dec 03, 2005 at 05:07:06PM -0200, Otavio Salvador wrote:
> The prototype of btext_init function was missing and then caused a compile
> warning.
>
> ---
>
> include/asm-ppc/btext.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> applies-to: 60e8ae37378de2772b6b0768b12a49f923710152
> 786b869f9cfd4c1f82fbc8b20fa8cafb9188e12f
> diff --git a/include/asm-ppc/btext.h b/include/asm-ppc/btext.h
> index ccaefab..2329331 100644
> --- a/include/asm-ppc/btext.h
> +++ b/include/asm-ppc/btext.h
> @@ -18,6 +18,7 @@ extern boot_infos_t disp_bi;
> extern int boot_text_mapped;
>
> extern void init_boot_display(void);
> +extern void __init btext_init(boot_infos_t *bi);
> extern void btext_welcome(void);
> extern void btext_prepare_BAT(void);
> extern void btext_setup_display(int width, int height, int depth, int pitch,
"__init" should be placed between closing brace and semicolon. For
more info, see include/linux/init.h
--
Eugene
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
2005-12-03 21:24 ` Eugene Surovegin
@ 2005-12-03 21:31 ` Otavio Salvador
2005-12-03 21:33 ` Otavio Salvador
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Otavio Salvador @ 2005-12-03 21:31 UTC (permalink / raw)
To: linuxppc-dev; +Cc: akpm
Eugene Surovegin <ebs@ebshome.net> writes:
...
>> +extern void __init btext_init(boot_infos_t *bi);
...
>
> "__init" should be placed between closing brace and semicolon. For
> more info, see include/linux/init.h
Ok. Thanks, I'll resend the patch.
--
O T A V I O S A L V A D O R
---------------------------------------------
E-mail: otavio@debian.org UIN: 5906116
GNU/Linux User: 239058 GPG ID: 49A5F855
Home Page: http://www.freedom.ind.br/otavio
---------------------------------------------
"Microsoft gives you Windows ... Linux gives
you the whole house."
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
2005-12-03 21:24 ` Eugene Surovegin
2005-12-03 21:31 ` Otavio Salvador
@ 2005-12-03 21:33 ` Otavio Salvador
2005-12-04 0:00 ` Andrew Morton
2005-12-04 2:21 ` Paul Mackerras
3 siblings, 0 replies; 8+ messages in thread
From: Otavio Salvador @ 2005-12-03 21:33 UTC (permalink / raw)
To: linuxppc-dev, akpm, Eugene Surovegin; +Cc: Otavio Salvador
The prototype of btext_init function was missing and then caused a compile
warning.
---
include/asm-ppc/btext.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
applies-to: 60e8ae37378de2772b6b0768b12a49f923710152
19174aa31fd85e4410e99deb82c3b7ff2424fa55
diff --git a/include/asm-ppc/btext.h b/include/asm-ppc/btext.h
index ccaefab..2cf437c 100644
--- a/include/asm-ppc/btext.h
+++ b/include/asm-ppc/btext.h
@@ -18,6 +18,7 @@ extern boot_infos_t disp_bi;
extern int boot_text_mapped;
extern void init_boot_display(void);
+extern void btext_init(boot_infos_t *bi) __init;
extern void btext_welcome(void);
extern void btext_prepare_BAT(void);
extern void btext_setup_display(int width, int height, int depth, int pitch,
---
0.99.9k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
2005-12-03 21:24 ` Eugene Surovegin
2005-12-03 21:31 ` Otavio Salvador
2005-12-03 21:33 ` Otavio Salvador
@ 2005-12-04 0:00 ` Andrew Morton
2005-12-04 0:12 ` Eugene Surovegin
2005-12-04 21:13 ` Geert Uytterhoeven
2005-12-04 2:21 ` Paul Mackerras
3 siblings, 2 replies; 8+ messages in thread
From: Andrew Morton @ 2005-12-04 0:00 UTC (permalink / raw)
To: Eugene Surovegin; +Cc: linuxppc-dev, otavio
Eugene Surovegin <ebs@ebshome.net> wrote:
>
> > +extern void __init btext_init(boot_infos_t *bi);
> > extern void btext_welcome(void);
> > extern void btext_prepare_BAT(void);
> > extern void btext_setup_display(int width, int height, int depth, int pitch,
>
> "__init" should be placed between closing brace and semicolon. For
> more info, see include/linux/init.h
I don't think it matters much. Often we just omit it from the declaration
- it's only required at the definition site
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
2005-12-04 0:00 ` Andrew Morton
@ 2005-12-04 0:12 ` Eugene Surovegin
2005-12-04 21:13 ` Geert Uytterhoeven
1 sibling, 0 replies; 8+ messages in thread
From: Eugene Surovegin @ 2005-12-04 0:12 UTC (permalink / raw)
To: Andrew Morton; +Cc: linuxppc-dev, otavio
On Sat, Dec 03, 2005 at 04:00:20PM -0800, Andrew Morton wrote:
> Eugene Surovegin <ebs@ebshome.net> wrote:
> >
> > > +extern void __init btext_init(boot_infos_t *bi);
> > > extern void btext_welcome(void);
> > > extern void btext_prepare_BAT(void);
> > > extern void btext_setup_display(int width, int height, int depth, int pitch,
> >
> > "__init" should be placed between closing brace and semicolon. For
> > more info, see include/linux/init.h
>
> I don't think it matters much. Often we just omit it from the declaration
> - it's only required at the definition site
Quite likely it doesn't matter, but I think we should follow existing
style, if not for correctness, but at least for consistency (it
actually caught my eye exactly because it _looked_ different). I'm
pretty sure original poster have tested original version :).
--
Eugene
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
2005-12-04 0:00 ` Andrew Morton
2005-12-04 0:12 ` Eugene Surovegin
@ 2005-12-04 21:13 ` Geert Uytterhoeven
1 sibling, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2005-12-04 21:13 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux/PPC Development, otavio
On Sat, 3 Dec 2005, Andrew Morton wrote:
> Eugene Surovegin <ebs@ebshome.net> wrote:
> > > +extern void __init btext_init(boot_infos_t *bi);
> > > extern void btext_welcome(void);
> > > extern void btext_prepare_BAT(void);
> > > extern void btext_setup_display(int width, int height, int depth, int pitch,
> >
> > "__init" should be placed between closing brace and semicolon. For
> > more info, see include/linux/init.h
>
> I don't think it matters much. Often we just omit it from the declaration
> - it's only required at the definition site
IIRC, on Alpha it's needed/recommended on both, to allow the compiler to
optimize jumps to the same section?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
2005-12-03 21:24 ` Eugene Surovegin
` (2 preceding siblings ...)
2005-12-04 0:00 ` Andrew Morton
@ 2005-12-04 2:21 ` Paul Mackerras
3 siblings, 0 replies; 8+ messages in thread
From: Paul Mackerras @ 2005-12-04 2:21 UTC (permalink / raw)
To: Eugene Surovegin; +Cc: akpm, linuxppc-dev, Otavio Salvador
Eugene Surovegin writes:
> "__init" should be placed between closing brace and semicolon. For
> more info, see include/linux/init.h
Actually, there's no point putting __init in an extern declaration.
Paul.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2005-12-04 21:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-03 19:07 [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function Otavio Salvador
2005-12-03 21:24 ` Eugene Surovegin
2005-12-03 21:31 ` Otavio Salvador
2005-12-03 21:33 ` Otavio Salvador
2005-12-04 0:00 ` Andrew Morton
2005-12-04 0:12 ` Eugene Surovegin
2005-12-04 21:13 ` Geert Uytterhoeven
2005-12-04 2:21 ` Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).